From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A20BEA2EEB for ; Tue, 10 Sep 2019 10:53:10 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B085D1EBB9; Tue, 10 Sep 2019 10:53:09 +0200 (CEST) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id E56D81EB87 for ; Tue, 10 Sep 2019 10:53:07 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (webmail.solarflare.com [12.187.104.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us3.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 32196480079; Tue, 10 Sep 2019 08:53:06 +0000 (UTC) Received: from ocex03.SolarFlarecom.com (10.20.40.36) by ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 10 Sep 2019 01:53:03 -0700 Received: from opal.uk.solarflarecom.com (10.17.10.1) by ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1395.4 via Frontend Transport; Tue, 10 Sep 2019 01:53:03 -0700 Received: from ukv-loginhost.uk.solarflarecom.com (ukv-loginhost.uk.solarflarecom.com [10.17.10.39]) by opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id x8A8r14R024699; Tue, 10 Sep 2019 09:53:01 +0100 Received: from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1]) by ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id 9DAB71613D1; Tue, 10 Sep 2019 09:53:01 +0100 (BST) From: Andrew Rybchenko To: Thomas Monjalon , Ferruh Yigit , Chas Williams CC: , Igor Romanov Date: Tue, 10 Sep 2019 09:52:14 +0100 Message-ID: <1568105541-7399-1-git-send-email-arybchenko@solarflare.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24898.005 X-TM-AS-Result: No-1.564900-4.000000-10 X-TMASE-MatchedRID: 6dwGUAy65sEwpyA3tQmxTVzQnJ/mQ5H8APiR4btCEebM3LZfC40TVCjQ SoDXfNBztRPNboRYOBHfrd9voQGByVTNH/IEdCNmB7TqRAYVohapSpNJXHTi8b0rWM4nIpJrwBI zUVtFoCK+tvyhGmvHmeUJ7/ZE0DXJMKK3MQ624rVyAOhmFi1q9ulUxvXGcRIytQ/I77hJvmXksM P82WSDVXNmSCNBhZgfN1KUExYOWSS6/eEqqZaZmp1U1lojafr/W1eClGWYNyhs98Z8fG/6kSy1E ha6RmdH8p3dV/oXk/OQKl4RwWngigwrHZI4GgKmPja3w1ExF8QlRO0keKqPA8d4gWcpDnUcjBYh GYtVarksvhUdVVnNYZTJQl/HUCOQJlKF+jTbh/ED2WXLXdz+AU7IcXpDuZ9LuSti1BoHqPY6rpg CnO/ZYeKT9HB8HNIrgDLqnrRlXrZ8nn9tnqel2Ku+08oqCcwYxY6xb6BhpqbTsoSf4XaQNNKuZg ZJcR/O5r0AD/NolrreX4cXPPxtcOoA8a7JSV3ZEgLY3SNhFBuuVMZvn5wI5T8U672htNP08Oycc FNBL2TKhETi2//sjuP9Cb59K8ACZrS+A8PszW9jS2VwPKV+lVZca9RSYo/b X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10-1.564900-4.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24898.005 X-MDID: 1568105587-7etb1PomiJ70 Subject: [dpdk-dev] [PATCH 0/7] ethdev: change MAC addr get function return value to int X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" It is the sixth patch series to get rid of void returning functions in ethdev in accordance with deprecation notice [1]. It should be applied on top of [2], [3], [4], [5] and [6]. Functions which return void are bad since they do not provide explicit information to the caller if everything is OK or not. In the case of MAC address get it is important to know if MAC address is filled in or not and existing function simply keeps it uninitialized if port ID is invalid. There is no driver callback to get MAC address. The driver must fill it in in ethdev data. net/bonding actively uses the function but not updated to take return value into account since it is not always obvious what to do in the case of failure. Also bonding autotest and examples/bond have many lines longer than 80 symbols and the warning is ignored on update. [1] https://patches.dpdk.org/patch/56969/ [2] https://patches.dpdk.org/project/dpdk/list/?series=6279 [3] https://patches.dpdk.org/project/dpdk/list/?series=6334 [4] https://patches.dpdk.org/project/dpdk/list/?series=6335 [5] https://patches.dpdk.org/project/dpdk/list/?series=6308 [6] https://patches.dpdk.org/project/dpdk/list/?series=6350 Igor Romanov (7): ethdev: change MAC addr get function return value to int app/testpmd: check status of getting MAC address app/pdump: check status of getting MAC address app/test: check status of getting MAC address app/test: check status of getting MAC address in bonding examples: check status of getting MAC address examples/bond: check status of getting MAC address app/pdump/main.c | 5 +- app/test-pmd/config.c | 14 +- app/test-pmd/testpmd.c | 13 +- app/test-pmd/testpmd.h | 2 + app/test-pmd/util.c | 13 + app/test/test_event_eth_rx_adapter.c | 4 +- app/test/test_event_eth_tx_adapter.c | 4 +- app/test/test_link_bonding.c | 304 +++++++++++++----- app/test/test_link_bonding_mode4.c | 14 +- app/test/test_pmd_perf.c | 7 +- doc/guides/rel_notes/deprecation.rst | 1 - doc/guides/rel_notes/release_19_11.rst | 3 + doc/guides/sample_app_ug/flow_classify.rst | 4 +- examples/bbdev_app/main.c | 8 +- examples/bond/main.c | 58 +++- examples/distributor/main.c | 8 +- examples/ethtool/ethtool-app/main.c | 18 +- examples/ethtool/lib/rte_ethtool.c | 7 +- examples/eventdev_pipeline/main.c | 8 +- examples/flow_classify/flow_classify.c | 5 +- examples/ip_fragmentation/main.c | 9 +- examples/ip_pipeline/cli.c | 8 +- examples/ip_reassembly/main.c | 9 +- examples/ipsec-secgw/ipsec-secgw.c | 7 +- examples/ipv4_multicast/main.c | 7 +- examples/kni/main.c | 6 +- examples/l2fwd-cat/l2fwd-cat.c | 5 +- examples/l2fwd-crypto/main.c | 8 +- examples/l2fwd-jobstats/main.c | 7 +- examples/l2fwd-keepalive/main.c | 7 +- examples/l2fwd/main.c | 7 +- examples/l3fwd-acl/main.c | 7 +- examples/l3fwd-power/main.c | 7 +- examples/l3fwd-vf/main.c | 7 +- examples/l3fwd/main.c | 7 +- examples/link_status_interrupt/main.c | 6 +- .../client_server_mp/mp_server/main.c | 8 +- examples/packet_ordering/main.c | 8 +- .../performance-thread/l3fwd-thread/main.c | 7 +- examples/ptpclient/ptpclient.c | 11 +- examples/quota_watermark/qw/main.c | 10 +- examples/rxtx_callbacks/main.c | 7 +- examples/server_node_efd/server/main.c | 9 +- examples/skeleton/basicfwd.c | 5 +- examples/tep_termination/vxlan_setup.c | 5 +- examples/vhost/main.c | 9 +- examples/vm_power_manager/guest_cli/main.c | 11 +- .../guest_cli/vm_power_cli_guest.c | 17 +- .../guest_cli/vm_power_cli_guest.h | 2 +- examples/vm_power_manager/main.c | 8 +- examples/vmdq/main.c | 7 +- examples/vmdq_dcb/main.c | 7 +- lib/librte_ethdev/rte_ethdev.c | 6 +- lib/librte_ethdev/rte_ethdev.h | 5 +- 54 files changed, 604 insertions(+), 152 deletions(-) -- 2.17.1