* [dpdk-dev] [PATCH] kni: support RHEL 7.3
@ 2016-09-14 18:25 Pablo de Lara
2016-09-15 10:12 ` Ferruh Yigit
2016-09-16 21:01 ` [dpdk-dev] [PATCH v2] " Pablo de Lara
0 siblings, 2 replies; 6+ messages in thread
From: Pablo de Lara @ 2016-09-14 18:25 UTC (permalink / raw)
To: dev; +Cc: ferruh.yigit, Pablo de Lara
Add support for RHEL 7.3, which uses kernel 3.10,
but backported features from newer kernels.
Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h b/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h
index bdd0806..1e20a9e 100644
--- a/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h
+++ b/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h
@@ -3891,7 +3891,7 @@ skb_set_hash(struct sk_buff *skb, __u32 hash, __always_unused int type)
#if (( LINUX_VERSION_CODE >= KERNEL_VERSION(3,19,0) ) \
|| ( RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7,2) ))
#define HAVE_NDO_DFLT_BRIDGE_ADD_MASK
-#if (!( RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7,2) ))
+#if (!( RHEL_RELEASE_CODE == RHEL_RELEASE_VERSION(7,2) ))
#define HAVE_NDO_FDB_ADD_VID
#endif /* !RHEL 7.2 */
#endif /* >= 3.19.0 */
@@ -3901,12 +3901,13 @@ skb_set_hash(struct sk_buff *skb, __u32 hash, __always_unused int type)
/* vlan_tx_xx functions got renamed to skb_vlan */
#define vlan_tx_tag_get skb_vlan_tag_get
#define vlan_tx_tag_present skb_vlan_tag_present
-#if (!( RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7,2) ))
+#if (!( RHEL_RELEASE_CODE == RHEL_RELEASE_VERSION(7,2) ))
#define HAVE_NDO_BRIDGE_SET_DEL_LINK_FLAGS
#endif /* !RHEL 7.2 */
#endif /* 4.0.0 */
-#if ( LINUX_VERSION_CODE >= KERNEL_VERSION(4,1,0) )
+#if (( LINUX_VERSION_CODE >= KERNEL_VERSION(4,1,0) ) \
+ || ( RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7,3) ))
/* ndo_bridge_getlink adds new nlflags parameter */
#define HAVE_NDO_BRIDGE_GETLINK_NLFLAGS
#endif /* >= 4.1.0 */
--
2.7.4
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH] kni: support RHEL 7.3
2016-09-14 18:25 [dpdk-dev] [PATCH] kni: support RHEL 7.3 Pablo de Lara
@ 2016-09-15 10:12 ` Ferruh Yigit
2016-09-15 22:52 ` De Lara Guarch, Pablo
2016-09-16 21:01 ` [dpdk-dev] [PATCH v2] " Pablo de Lara
1 sibling, 1 reply; 6+ messages in thread
From: Ferruh Yigit @ 2016-09-15 10:12 UTC (permalink / raw)
To: Pablo de Lara, dev
On 9/14/2016 7:25 PM, Pablo de Lara wrote:
> Add support for RHEL 7.3, which uses kernel 3.10,
> but backported features from newer kernels.
>
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> ---
> lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h b/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h
> index bdd0806..1e20a9e 100644
> --- a/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h
> +++ b/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h
> @@ -3891,7 +3891,7 @@ skb_set_hash(struct sk_buff *skb, __u32 hash, __always_unused int type)
> #if (( LINUX_VERSION_CODE >= KERNEL_VERSION(3,19,0) ) \
> || ( RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7,2) ))
> #define HAVE_NDO_DFLT_BRIDGE_ADD_MASK
> -#if (!( RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7,2) ))
> +#if (!( RHEL_RELEASE_CODE == RHEL_RELEASE_VERSION(7,2) ))
What about following to simplify the logic:
+#if ( RHEL_RELEASE_CODE != RHEL_RELEASE_VERSION(7,2) )
Thanks,
ferruh
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] kni: support RHEL 7.3
2016-09-15 10:12 ` Ferruh Yigit
@ 2016-09-15 22:52 ` De Lara Guarch, Pablo
0 siblings, 0 replies; 6+ messages in thread
From: De Lara Guarch, Pablo @ 2016-09-15 22:52 UTC (permalink / raw)
To: Yigit, Ferruh, dev
> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Thursday, September 15, 2016 3:13 AM
> To: De Lara Guarch, Pablo; dev@dpdk.org
> Subject: Re: [PATCH] kni: support RHEL 7.3
>
> On 9/14/2016 7:25 PM, Pablo de Lara wrote:
> > Add support for RHEL 7.3, which uses kernel 3.10,
> > but backported features from newer kernels.
> >
> > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> > ---
> > lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h | 7 ++++---
> > 1 file changed, 4 insertions(+), 3 deletions(-)
> >
> > diff --git a/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h
> b/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h
> > index bdd0806..1e20a9e 100644
> > --- a/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h
> > +++ b/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h
> > @@ -3891,7 +3891,7 @@ skb_set_hash(struct sk_buff *skb, __u32 hash,
> __always_unused int type)
> > #if (( LINUX_VERSION_CODE >= KERNEL_VERSION(3,19,0) ) \
> > || ( RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7,2) ))
> > #define HAVE_NDO_DFLT_BRIDGE_ADD_MASK
> > -#if (!( RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7,2) ))
> > +#if (!( RHEL_RELEASE_CODE == RHEL_RELEASE_VERSION(7,2) ))
>
> What about following to simplify the logic:
> +#if ( RHEL_RELEASE_CODE != RHEL_RELEASE_VERSION(7,2) )
>
Good point. Will send a v2 with that :)
Thanks,
Pablo
> Thanks,
> ferruh
^ permalink raw reply [flat|nested] 6+ messages in thread
* [dpdk-dev] [PATCH v2] kni: support RHEL 7.3
2016-09-14 18:25 [dpdk-dev] [PATCH] kni: support RHEL 7.3 Pablo de Lara
2016-09-15 10:12 ` Ferruh Yigit
@ 2016-09-16 21:01 ` Pablo de Lara
2016-09-19 9:01 ` Ferruh Yigit
1 sibling, 1 reply; 6+ messages in thread
From: Pablo de Lara @ 2016-09-16 21:01 UTC (permalink / raw)
To: dev; +Cc: ferruh.yigit, stable, Pablo de Lara
Add support for RHEL 7.3, which uses kernel 3.10,
but backported features from newer kernels.
Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
Changes in v2:
- Simplified conditional logic
lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h b/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h
index bdd0806..e28d113 100644
--- a/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h
+++ b/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h
@@ -3891,7 +3891,7 @@ skb_set_hash(struct sk_buff *skb, __u32 hash, __always_unused int type)
#if (( LINUX_VERSION_CODE >= KERNEL_VERSION(3,19,0) ) \
|| ( RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7,2) ))
#define HAVE_NDO_DFLT_BRIDGE_ADD_MASK
-#if (!( RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7,2) ))
+#if ( RHEL_RELEASE_CODE != RHEL_RELEASE_VERSION(7,2) )
#define HAVE_NDO_FDB_ADD_VID
#endif /* !RHEL 7.2 */
#endif /* >= 3.19.0 */
@@ -3901,12 +3901,13 @@ skb_set_hash(struct sk_buff *skb, __u32 hash, __always_unused int type)
/* vlan_tx_xx functions got renamed to skb_vlan */
#define vlan_tx_tag_get skb_vlan_tag_get
#define vlan_tx_tag_present skb_vlan_tag_present
-#if (!( RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7,2) ))
+#if ( RHEL_RELEASE_CODE != RHEL_RELEASE_VERSION(7,2) )
#define HAVE_NDO_BRIDGE_SET_DEL_LINK_FLAGS
#endif /* !RHEL 7.2 */
#endif /* 4.0.0 */
-#if ( LINUX_VERSION_CODE >= KERNEL_VERSION(4,1,0) )
+#if (( LINUX_VERSION_CODE >= KERNEL_VERSION(4,1,0) ) \
+ || ( RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7,3) ))
/* ndo_bridge_getlink adds new nlflags parameter */
#define HAVE_NDO_BRIDGE_GETLINK_NLFLAGS
#endif /* >= 4.1.0 */
--
2.7.4
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH v2] kni: support RHEL 7.3
2016-09-16 21:01 ` [dpdk-dev] [PATCH v2] " Pablo de Lara
@ 2016-09-19 9:01 ` Ferruh Yigit
2016-09-21 16:11 ` Thomas Monjalon
0 siblings, 1 reply; 6+ messages in thread
From: Ferruh Yigit @ 2016-09-19 9:01 UTC (permalink / raw)
To: Pablo de Lara, dev; +Cc: stable
On 9/16/2016 10:01 PM, Pablo de Lara wrote:
> Add support for RHEL 7.3, which uses kernel 3.10,
> but backported features from newer kernels.
>
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> ---
Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH v2] kni: support RHEL 7.3
2016-09-19 9:01 ` Ferruh Yigit
@ 2016-09-21 16:11 ` Thomas Monjalon
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Monjalon @ 2016-09-21 16:11 UTC (permalink / raw)
To: Pablo de Lara; +Cc: dev, Ferruh Yigit, stable
2016-09-19 10:01, Ferruh Yigit:
> On 9/16/2016 10:01 PM, Pablo de Lara wrote:
> > Add support for RHEL 7.3, which uses kernel 3.10,
> > but backported features from newer kernels.
> >
> > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> > ---
>
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-09-21 16:11 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-14 18:25 [dpdk-dev] [PATCH] kni: support RHEL 7.3 Pablo de Lara
2016-09-15 10:12 ` Ferruh Yigit
2016-09-15 22:52 ` De Lara Guarch, Pablo
2016-09-16 21:01 ` [dpdk-dev] [PATCH v2] " Pablo de Lara
2016-09-19 9:01 ` Ferruh Yigit
2016-09-21 16:11 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).