From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 41E5D1B505 for ; Thu, 4 Oct 2018 18:30:54 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id CCCBD21F73; Thu, 4 Oct 2018 12:30:53 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 04 Oct 2018 12:30:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=Zpdv7hG++bNPGMufhml05r7hn9qRJN2e89iuHuLvFk0=; b=A3cA/7fbTPg/ 2rQDs8MJLVlHatN13QaSDeayZYul+/VaRo6V29yekVA7vufK1zV59cT0SUF4n2sE svpEaoa2f5LKUbS7Myfnrp8imMaqpNhlTTHjvfg0nUZQjdwL1J7jaXwHJHg6Vco0 SwkT/cAYQGmTG0fXUc+RvLRbE4GLYQo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=Zpdv7hG++bNPGMufhml05r7hn9qRJN2e89iuHuLvF k0=; b=pqU9KaQG1E1+1CTa5vGu5g0c+9UOfFevKDWT/Ut+8qc4eMU7/bCskU1Yv 2xUv02QeKno/Jl25bPsDk6F9uWnh9wuffLJyD5BBp0iEi0+Oa1ers0cYMWge0wdn UADvAXLOa6/yGJ7P8c2Izm+UhA6FGlEvk2dvWuSOO+Lh48YKub+I4wjv1k+GpNNg 5npeOn/pa2RSYVjcSg/uhEWy8EbKSiPwqWt2OgxpVdKeAxuQs1A0II+MVEH/osiu Xz5kxeC/HXfeC0sdknvy6gTJoms9TE6N1eMbFLEJk/lvoISwlcem/yJNRTGjIPAH pyMfWfdFNX9hwZ2b+BqpK+w6u8Ycw== X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 98DE0E479F; Thu, 4 Oct 2018 12:30:51 -0400 (EDT) From: Thomas Monjalon To: Mattias =?ISO-8859-1?Q?R=F6nnblom?= , Jerin Jacob Cc: dev@dpdk.org, Ferruh Yigit Date: Thu, 04 Oct 2018 18:30:50 +0200 Message-ID: <1568909.fdk1z5rJxs@xps> In-Reply-To: <2641514.GnYxfkIzXT@xps> References: <20181003081353.6679-1-mattias.ronnblom@ericsson.com> <37910565-67d7-ff1e-aaea-65418be890a7@intel.com> <2641514.GnYxfkIzXT@xps> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" Subject: Re: [dpdk-dev] [PATCH] event/dsw: avoid supplying -Wno-format-nonliteral to icc X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Oct 2018 16:30:54 -0000 04/10/2018 18:09, Thomas Monjalon: > 03/10/2018 21:18, Ferruh Yigit: > > On 10/3/2018 9:13 AM, Mattias R=F6nnblom wrote: > > > Make the -Wno-format-nonliteral flag conditional, and only set in > > > clang and gcc builds, since this flag is not supported (nor needed) > > > when building with icc. > > >=20 > > > Signed-off-by: Mattias R=F6nnblom > >=20 > > perhaps simply: "event/dsw: fix icc build" > >=20 > > Fixes: 46a186b1f0c5 ("event/dsw: add device registration and build syst= em") > >=20 > > Reviewed-by: Ferruh Yigit >=20 > Applied, thanks Cancelled as a v2 was applied in next-event tree. Advices to avoid such confusion: - the v1 must be marked as superseded in patchwork - the v2 must be in the same thread thanks to --in-reply-to And thanks Ferruh for spotting this :)