* [dpdk-dev] [PATCH] event/dsw: avoid supplying -Wno-format-nonliteral to icc
@ 2018-10-03 8:13 Mattias Rönnblom
2018-10-03 19:18 ` Ferruh Yigit
0 siblings, 1 reply; 4+ messages in thread
From: Mattias Rönnblom @ 2018-10-03 8:13 UTC (permalink / raw)
To: Jerin Jacob; +Cc: Ferruh Yigit, dev, Mattias Rönnblom
Make the -Wno-format-nonliteral flag conditional, and only set in
clang and gcc builds, since this flag is not supported (nor needed)
when building with icc.
Signed-off-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>
---
drivers/event/dsw/Makefile | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/event/dsw/Makefile b/drivers/event/dsw/Makefile
index ea1e5259a..490ed0b98 100644
--- a/drivers/event/dsw/Makefile
+++ b/drivers/event/dsw/Makefile
@@ -8,7 +8,9 @@ LIB = librte_pmd_dsw_event.a
CFLAGS += -DALLOW_EXPERIMENTAL_API
CFLAGS += -O3
CFLAGS += $(WERROR_FLAGS)
+ifneq ($(CONFIG_RTE_TOOLCHAIN_ICC),y)
CFLAGS += -Wno-format-nonliteral
+endif
LDLIBS += -lrte_eal
LDLIBS += -lrte_mbuf
--
2.17.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] event/dsw: avoid supplying -Wno-format-nonliteral to icc
2018-10-03 8:13 [dpdk-dev] [PATCH] event/dsw: avoid supplying -Wno-format-nonliteral to icc Mattias Rönnblom
@ 2018-10-03 19:18 ` Ferruh Yigit
2018-10-04 16:09 ` Thomas Monjalon
0 siblings, 1 reply; 4+ messages in thread
From: Ferruh Yigit @ 2018-10-03 19:18 UTC (permalink / raw)
To: Mattias Rönnblom, Jerin Jacob; +Cc: dev
On 10/3/2018 9:13 AM, Mattias Rönnblom wrote:
> Make the -Wno-format-nonliteral flag conditional, and only set in
> clang and gcc builds, since this flag is not supported (nor needed)
> when building with icc.
>
> Signed-off-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>
perhaps simply: "event/dsw: fix icc build"
Fixes: 46a186b1f0c5 ("event/dsw: add device registration and build system")
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] event/dsw: avoid supplying -Wno-format-nonliteral to icc
2018-10-03 19:18 ` Ferruh Yigit
@ 2018-10-04 16:09 ` Thomas Monjalon
2018-10-04 16:30 ` Thomas Monjalon
0 siblings, 1 reply; 4+ messages in thread
From: Thomas Monjalon @ 2018-10-04 16:09 UTC (permalink / raw)
To: Mattias Rönnblom; +Cc: dev, Ferruh Yigit, Jerin Jacob
03/10/2018 21:18, Ferruh Yigit:
> On 10/3/2018 9:13 AM, Mattias Rönnblom wrote:
> > Make the -Wno-format-nonliteral flag conditional, and only set in
> > clang and gcc builds, since this flag is not supported (nor needed)
> > when building with icc.
> >
> > Signed-off-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>
>
> perhaps simply: "event/dsw: fix icc build"
>
> Fixes: 46a186b1f0c5 ("event/dsw: add device registration and build system")
>
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] event/dsw: avoid supplying -Wno-format-nonliteral to icc
2018-10-04 16:09 ` Thomas Monjalon
@ 2018-10-04 16:30 ` Thomas Monjalon
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2018-10-04 16:30 UTC (permalink / raw)
To: Mattias Rönnblom, Jerin Jacob; +Cc: dev, Ferruh Yigit
04/10/2018 18:09, Thomas Monjalon:
> 03/10/2018 21:18, Ferruh Yigit:
> > On 10/3/2018 9:13 AM, Mattias Rönnblom wrote:
> > > Make the -Wno-format-nonliteral flag conditional, and only set in
> > > clang and gcc builds, since this flag is not supported (nor needed)
> > > when building with icc.
> > >
> > > Signed-off-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>
> >
> > perhaps simply: "event/dsw: fix icc build"
> >
> > Fixes: 46a186b1f0c5 ("event/dsw: add device registration and build system")
> >
> > Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
> Applied, thanks
Cancelled as a v2 was applied in next-event tree.
Advices to avoid such confusion:
- the v1 must be marked as superseded in patchwork
- the v2 must be in the same thread thanks to --in-reply-to
And thanks Ferruh for spotting this :)
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-10-04 16:30 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-03 8:13 [dpdk-dev] [PATCH] event/dsw: avoid supplying -Wno-format-nonliteral to icc Mattias Rönnblom
2018-10-03 19:18 ` Ferruh Yigit
2018-10-04 16:09 ` Thomas Monjalon
2018-10-04 16:30 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).