From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 63C281B040 for ; Sun, 7 Jan 2018 21:33:04 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id BE948206DB; Sun, 7 Jan 2018 15:33:03 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Sun, 07 Jan 2018 15:33:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=VSQyJJrOotyRrPaEm9XbjvrLP5 mAm8NrwRGimN1/gN8=; b=fNQCNy8h7Pc9G8d9vRRpkHyiMsv3VeFRzlvHTYmI7x XpYMuVN+c91WnTIG0H1WKcE2C4reG4hqikq925B0Uy4mwmW0uae+HPwIv9aMES02 IEmDrpWa9QbBiqFUl6ZjGjPW5dJsSs3Bdp6duXQ8TS7F7Qtm0n4HgtjBMVkJhWVI w= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=VSQyJJ rOotyRrPaEm9XbjvrLP5mAm8NrwRGimN1/gN8=; b=IM4wDCt/BItr2QqwYLg1lz BpdUqssAbL5Ugg0uFVDSTxYRuFxBLZPjlJDoY8yV0wxyXvxjHRsxwd1m0WP/YARC 6+qlwK8BUynqmfE9NQcJS93WAJ1w3teGn6i32YXAtRWrvdjDCyRZVTf/KZIy9y0P aziQGOm0ZhQkMyBfzYdpTBPRBPVsA2ryAE5y7/rWJ+D0cFVvnk/j65DSk5FDkF/G pg2QAKFftBGsn3e2id1LN+dWmzOvJ+JACllxo20NeT9Ozwbd3p8ZWq1QqQO4+ofo RgwLy2fHKpUGRgm7bEPqF77XUOFsZ/HT90/T8jTz2SwqK0BOgpZ2VBGVotRz4APg == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 7672424837; Sun, 7 Jan 2018 15:33:03 -0500 (EST) From: Thomas Monjalon To: Qiming Yang Cc: Shahaf Shuler , Andrew Rybchenko , dev@dpdk.org Date: Sun, 07 Jan 2018 21:32:40 +0100 Message-ID: <1569196.tzFYU9QD0F@xps> In-Reply-To: References: <20180104181506.153697-1-qiming.yang@intel.com> <3cf12026-efe5-6090-0bb1-4f9cba721ed9@solarflare.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [DPDK] lib/librte_ether: add comments RSS flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 07 Jan 2018 20:33:04 -0000 07/01/2018 07:32, Shahaf Shuler: > Saturday, January 6, 2018 12:22 PM, Andrew Rybchenko: > > [..] > > > > #define ETH_RSS_PORT (1ULL << RTE_ETH_FLOW_PORT) > > > +/** Enable RSS offload on VXLAN packets */ > > > #define ETH_RSS_VXLAN (1ULL << RTE_ETH_FLOW_VXLAN) > > > +/** Enable RSS offload on GENEVE packets */ > > > #define ETH_RSS_GENEVE (1ULL << RTE_ETH_FLOW_GENEVE) > > > +/** Enable RSS offload on NVGRE packets */ > > > #define ETH_RSS_NVGRE (1ULL << RTE_ETH_FLOW_NVGRE) > > > > > > #define ETH_RSS_IP ( \ > > > > These comments just decode the define name and not that useful. What > > would be really useful here is specification of which fields of the packet > > headers are used to calculate hash especially in the case of tunnels. > > +1. > > Also maybe some more clarifications, for example: > 1. What is the expected behavior when, for example, setting the ETH_RSS_IPV6_EX and regular IPv6 packet arrives? is RSS apply on it? > 2. What is the expected behavior from the PMD when not supporting one of the RSS types? > For example most of the DPDK examples uses ETH_RSS_IP [1], however very few devices actually supports each and every RSS type. > Assuming such configuration returns with no error, what should application expect when unsupported packet type arrives. > > #define ETH_RSS_IP ( \ > ETH_RSS_IPV4 | \ > ETH_RSS_FRAG_IPV4 | \ > ETH_RSS_NONFRAG_IPV4_OTHER | \ > ETH_RSS_IPV6 | \ > ETH_RSS_FRAG_IPV6 | \ > ETH_RSS_NONFRAG_IPV6_OTHER | \ > ETH_RSS_IPV6_EX) +1 We really need a detailed documentation of the exact behaviour. It must be at least as detailed as lib/librte_mbuf/rte_mbuf_ptype.h. Thanks