From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id C50AB1B37D for ; Mon, 12 Feb 2018 17:23:54 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 9A2BA20C46; Mon, 12 Feb 2018 11:23:51 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Mon, 12 Feb 2018 11:23:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=m5gMER1X9A7LDfw3JKujefDMBW rUSl2JO3HGanTD24U=; b=jp2vh0M5fjeOG9sVTcdCo8cPjoUZ/KUsWNctYvydSX aouwuK+QpbA+tgRpGWeMpUqZhAOuzuIfK0EL1mFDO7rHdgQj88UATUeTsjmyeNw8 VrrZO+cL/Lx2PRJ4coFN8g1ZfPVvX8voECOsVaMNiQyDVuWvGkpZwMfEErOqkgZS E= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=m5gMER 1X9A7LDfw3JKujefDMBWrUSl2JO3HGanTD24U=; b=WSFLfqFskHhS1W4VEZbtb8 szNQDV2zNkHCeu0MsQiSq4WlHo2B0PmeWnCVhg9sr3iDCe2TFbSlXsmdFbIYq6HV e4C9r024a0u5C1OFWfowrG9xkawZ8NljFVSD4HDsoRuE0U8CLINs9bFdsu3TaRML SbCcVnm1A27fa0+to4LATSEZnK6tyM/73ULc80NyEV69mgqtctdrPFhKbMKl/jAH CWrsNqrT54m9/Yels5P2pusUMLt8uinGfBBR6u78xrvttBLucTgbLdHTJ5aMz8Zm KZeepQiVoMBViTYhz4ZlzcDa5tLPgSaVO98L7patconKnd0XiNOIeqvmrI1kvDHQ == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 3804E245F1; Mon, 12 Feb 2018 11:23:51 -0500 (EST) From: Thomas Monjalon To: Adrien Mazarguil Cc: Ophir Munk , dev@dpdk.org, Moti Haimovsky , Olga Shern , Matan Azrad , ferruh.yigit@intel.com Date: Mon, 12 Feb 2018 17:23:41 +0100 Message-ID: <1569497.GkBoBtaCn5@xps> In-Reply-To: <20180212141958.GL4256@6wind.com> References: <1518072954-19082-1-git-send-email-ophirmu@mellanox.com> <5845713.HXRxCIfSL1@xps> <20180212141958.GL4256@6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v1] doc: update mlx4 flow limitations X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Feb 2018 16:23:55 -0000 12/02/2018 15:19, Adrien Mazarguil: > On Mon, Feb 12, 2018 at 02:58:31PM +0100, Thomas Monjalon wrote: > > 12/02/2018 12:23, Adrien Mazarguil: > > > On Fri, Feb 09, 2018 at 05:39:50PM +0100, Thomas Monjalon wrote: > > > > I think it's better to have some random thoughts than nothing. > > > > All the comments you gave in this thread deserve to be written in > > > > the documentation as soon as possible. > > > > > > Right, but as a side note in the meantime, more complete documentation is > > > already available in Doxygen format in mlx4_flow.c. *All* limitations are > > > also returned in plain text through error messages (rte_flow_error.message) > > > in the same file (git grep 'msg =' drivers/net/mlx4/mlx4_flow.c). > > > > OK, so we can just point to this file in the documentation and we are done. > > One remaining issue is that we do not generate documentation out of PMDs > since they do not expose public APIs. We can still somehow point to their > source code though. Yes, just mention the source code where the information is. It can help. And if you or Ophir think there is some outstanding limitations, we can just add a note with a sentence like: "One of the limitation important to be aware of is..."