From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 18032A2EDB for ; Tue, 1 Oct 2019 17:45:11 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A312B1BE9C; Tue, 1 Oct 2019 17:45:01 +0200 (CEST) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id C602E1BE97; Tue, 1 Oct 2019 17:44:59 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (webmail.solarflare.com [12.187.104.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us5.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 452C84C006D; Tue, 1 Oct 2019 15:44:57 +0000 (UTC) Received: from ocex03.SolarFlarecom.com (10.20.40.36) by ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Tue, 1 Oct 2019 08:44:54 -0700 Received: from opal.uk.solarflarecom.com (10.17.10.1) by ocex03.SolarFlarecom.com (10.20.40.36) with Microsoft SMTP Server (TLS) id 15.0.1395.4 via Frontend Transport; Tue, 1 Oct 2019 08:44:54 -0700 Received: from ukv-loginhost.uk.solarflarecom.com (ukv-loginhost.uk.solarflarecom.com [10.17.10.39]) by opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id x91Firmp014920; Tue, 1 Oct 2019 16:44:53 +0100 Received: from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1]) by ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id F414F1613D1; Tue, 1 Oct 2019 16:44:52 +0100 (BST) From: Andrew Rybchenko To: Maxime Coquelin , Tiwei Bie , Zhihong Wang CC: , Dilshod Urazov , Date: Tue, 1 Oct 2019 16:44:31 +0100 Message-ID: <1569944672-24754-3-git-send-email-arybchenko@solarflare.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1569944672-24754-1-git-send-email-arybchenko@solarflare.com> References: <1569944672-24754-1-git-send-email-arybchenko@solarflare.com> MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24946.005 X-TM-AS-Result: No-2.461200-4.000000-10 X-TMASE-MatchedRID: n7nN31NWDDqB//TxCalW+rSkeRV328rMQ37rdi3NWIeyZWVsxGDcQPBU q5JsuvxSd04MXTR6LNt+EEFKtIVNxopCwExx8AipnMQdNQ64xfd6i696PjRPiB3RY4pGTCyHQBz oPKhLasijkL1tNPFpRk47ex7jmMHVYDYgBcRN64oqsMfMfrOZRTDoUQeQv/CP0SxMhOhuA0Tj3a QyxbuPYuqjnB98KgqAgDLqnrRlXrZ8nn9tnqel2K6NVEWSRWybUn41j4bZnDBh8/ReHwrqD3Drt ixZuNviA8yFl+C4Pb+hFaQifj/sjY8BawJtcjmRLC3048a8YJKnjQVIQ/YVvtlsMqfc5TfD8Oyc cFNBL2TKhETi2//sjuP9Cb59K8ACZrS+A8PszW+YV38c4KFOjw== X-TM-AS-User-Approved-Sender: No X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--2.461200-4.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24946.005 X-MDID: 1569944699-z2CuaDpy_Bne Subject: [dpdk-dev] [PATCH 3/3] net/virtio: reject unsupported Rx multi queue modes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Dilshod Urazov This driver supports none of DCB, RSS or VMDQ modes, therefore must check and return error if configured incorrectly. Fixes: c1f86306a026 ("virtio: add new driver") Cc: stable@dpdk.org Signed-off-by: Dilshod Urazov Signed-off-by: Andrew Rybchenko --- drivers/net/virtio/virtio_ethdev.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c index 7261109dd..0af4fc392 100644 --- a/drivers/net/virtio/virtio_ethdev.c +++ b/drivers/net/virtio/virtio_ethdev.c @@ -2071,6 +2071,13 @@ virtio_dev_configure(struct rte_eth_dev *dev) PMD_INIT_LOG(DEBUG, "configure"); req_features = VIRTIO_PMD_DEFAULT_GUEST_FEATURES; + if (rxmode->mq_mode != ETH_MQ_RX_NONE) { + PMD_DRV_LOG(ERR, + "Unsupported Rx multi queue mode %d", + rxmode->mq_mode); + return -EINVAL; + } + if (dev->data->dev_conf.intr_conf.rxq) { ret = virtio_init_device(dev, hw->req_guest_features); if (ret < 0) -- 2.17.1