From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Patrick Mahan <mahan@mahan.org>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] pci: fix non-Intel devices probing
Date: Mon, 16 Sep 2013 23:59:19 +0200 [thread overview]
Message-ID: <1570236.KP93u3nrzz@x220> (raw)
In-Reply-To: <BBFDF6C2-16DE-413B-8A68-DA85A68774DE@mahan.org>
16/09/2013 14:42, Patrick Mahan :
> On Sep 16, 2013, at 1:29 PM, Thomas Monjalon <thomas.monjalon@6wind.com>
wrote:
> > There is no need to check for bars mapping, especially BAR0 is not
> > required. If bars mapping failed, then pci_uio_map_resource will fail and
> > we won't reach this check. So get rid of BAR0 check.
> > Besides, pci_uio_map_resource should only be called for Intel devices.
> > The flag RTE_PCI_DRV_NEED_IGB_UIO is set for all Intel devices, even when
> > RTE_EAL_UNBIND_PORTS is disabled.
>
> I totally disagree with this statement. I am currently working on a
> non-intel device that does need UIO support (I copied the igb UIO to create
> a new UIO driver). This device not only needs bar0 but also bar1. I've
> modified the eal PCI support code to support this behavior and change this
> behavior would not be good, IMHO.
I don't know which statement you are talking about.
You are writing a PMD based on UIO. Will you send it on dpdk.org ?
In this release, the only PMDs using UIO are Intel ones.
Also as explained, this check is never needed.
But I think you are talking about support of BAR mapping. This is not changed
by this patch. Moreover, the BAR mapping is extended in coming release 1.4.1.
Note that it's simpler to discuss about a patch or a clearly pointed sentence.
So, please be more precise or send your patch proposal.
PS: please don't top-post
--
Thomas
next prev parent reply other threads:[~2013-09-16 21:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-16 20:29 Thomas Monjalon
2013-09-16 20:38 ` Thomas Monjalon
2013-09-16 21:42 ` Patrick Mahan
2013-09-16 21:59 ` Thomas Monjalon [this message]
2013-09-16 23:59 ` Stephen Hemminger
2013-09-17 10:21 ` [dpdk-dev] [PATCH v2 0/2] " Thomas Monjalon
2013-09-17 10:21 ` [dpdk-dev] [PATCH v2 1/2] pci: do not check BAR0 mapping Thomas Monjalon
2013-09-17 11:26 ` Damien Millescamps
2013-09-17 10:21 ` [dpdk-dev] [PATCH v2 2/2] pci: use igb_uio mapping only when needed Thomas Monjalon
2013-09-17 11:27 ` Damien Millescamps
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1570236.KP93u3nrzz@x220 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=mahan@mahan.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).