From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id AED3A11A4 for ; Sun, 31 Mar 2019 19:06:06 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 4474F21957; Sun, 31 Mar 2019 13:06:06 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sun, 31 Mar 2019 13:06:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=pweonAY3QOBTY6sKeMk8ORA3g/bOdLm9ochU4G63VUw=; b=d+/AqWnYlP3e 783+lMWcXoA2Do6rXAGBQxZE/xCYyIULQMVIs5aSvYzaXHmqLgxfj/q43QkAY3cZ ns2ak4yNRdAjc4FUqIUO2E1l7o4fy3NCDQHmsnbeh7iu4h6k93JINEmdNSmR5t2J +mNfJE/kr2OMF1QY88kJgEy6XcYZWxk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=pweonAY3QOBTY6sKeMk8ORA3g/bOdLm9ochU4G63V Uw=; b=Xhtbb+8LmlYKEDbt72Krc2C55Z7H3GTx3TEGi3YzGwcS2nYtMF843RxT9 wNJSAySlt8GNgi/yckjoMEfmWh3oP9zTyf8nlEcA4njFhwXan9K4x6DTul2E9ul2 Evx3fanfGItXpzfgzid4yylYPYCAAhTVxPmCMQWQlaZdaFincproQG+xtjN9E5XC MQ6taqg5dXHIGW98PoIIMwI+TqJdPzhkIAzSIU1J8VuaD7Z0vKN3qYglL44Ca3L/ dQVKDVG8ctMWylsxUqAX53c+sZBs95feurAm1ega80lS1ciSUzLyhixBkpTAXbcM oXwhVsb9zWjZOaJ0M3L7GwSgfINMA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrledvgdduuddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id AC714E46B8; Sun, 31 Mar 2019 13:06:04 -0400 (EDT) From: Thomas Monjalon To: "Zhang, Qi Z" Cc: dev@dpdk.org, "Lu, Wenzhuo" , "Yang, Qiming" , "Stillwell Jr, Paul M" , "Yigit, Ferruh" , cathal.ohare@intel.com, john.mcnamara@intel.com Date: Sun, 31 Mar 2019 19:06:03 +0200 Message-ID: <1570574.eaFxuQL18R@xps> In-Reply-To: <039ED4275CED7440929022BC67E7061153351DC4@SHSMSX103.ccr.corp.intel.com> References: <20190228055650.25237-1-qi.z.zhang@intel.com> <20190325054452.2616-1-qi.z.zhang@intel.com> <039ED4275CED7440929022BC67E7061153351DC4@SHSMSX103.ccr.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4 00/38] ice share code update. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 31 Mar 2019 17:06:07 -0000 25/03/2019 08:07, Zhang, Qi Z: > > Sync to latest kernel driver, main changes: > > 1. add DCB/FDIR support. > > 2. add more APIs in switch module. > > 3. code clean and bug fix. > > > > Qi Zhang (38): > > net/ice/base: add switch resource allocation and free > > net/ice/base: improve comments > > net/ice/base: add two helper functions > > net/ice/base: add helper macros > > net/ice/base: allow package copy to be used after resets > > net/ice/base: clean code > > net/ice/base: declare functions as external > > net/ice/base: add more APIs in switch module > > net/ice/base: add VSI queue context framework > > net/ice/base: add APIs to add remove ethertype filter > > net/ice/base: add APIs to get allocated resources > > net/ice/base: add APIs to alloc/free resource counter > > net/ice/base: add APIs to get VSI promiscuous mode > > net/ice/base: add MAC filter with marker and counter > > net/ice/base: add two helper functions for flow management > > net/ice/base: fix minor issues > > net/ice/base: update macros > > net/ice/base: clean code > > net/ice/base: enable VSI queue context > > net/ice/base: ensure only valid bits are set > > net/ice/base: enhance get link status command > > net/ice/base: add RSS key related macro and structures > > net/ice/base: do not write TCAM entries back > > net/ice/base: remove local VSIG allocations > > net/ice/base: fix minor issues > > net/ice/base: update copyright time > > net/ice/base: fix Klockwork analysis reported issues > > net/ice/base: return config error without queue to disable > > net/ice/base: add function to check FW recovery mode > > net/ice/base: change profile id reference counting > > net/ice/base: add DCB support > > net/ice/base: add FDIR support > > net/ice/base: change profile priority for RSS reply > > net/ice/base: fix duplicate resource allocations > > net/ice/base: fix minor issues > > net/ice/base: increase prototol offset size > > net/ice/base: revert the workaround for resource allocation > > net/ice/base: rework on bit ops > > Applied to dpdk-next-net-intel. > > Thanks > Qi 3 commits have the title "fix minor issues", that's a funny performance. When the ice PMD will enter in a serious phase, you should write some real commit titles and explain what are the fixed issues. For DPDK 19.05, I guess it's fine because ice PMD is not going to be really used soon, right? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 1BAB6A00B9 for ; Sun, 31 Mar 2019 19:06:09 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BF00F2B82; Sun, 31 Mar 2019 19:06:07 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id AED3A11A4 for ; Sun, 31 Mar 2019 19:06:06 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 4474F21957; Sun, 31 Mar 2019 13:06:06 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sun, 31 Mar 2019 13:06:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=pweonAY3QOBTY6sKeMk8ORA3g/bOdLm9ochU4G63VUw=; b=d+/AqWnYlP3e 783+lMWcXoA2Do6rXAGBQxZE/xCYyIULQMVIs5aSvYzaXHmqLgxfj/q43QkAY3cZ ns2ak4yNRdAjc4FUqIUO2E1l7o4fy3NCDQHmsnbeh7iu4h6k93JINEmdNSmR5t2J +mNfJE/kr2OMF1QY88kJgEy6XcYZWxk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=pweonAY3QOBTY6sKeMk8ORA3g/bOdLm9ochU4G63V Uw=; b=Xhtbb+8LmlYKEDbt72Krc2C55Z7H3GTx3TEGi3YzGwcS2nYtMF843RxT9 wNJSAySlt8GNgi/yckjoMEfmWh3oP9zTyf8nlEcA4njFhwXan9K4x6DTul2E9ul2 Evx3fanfGItXpzfgzid4yylYPYCAAhTVxPmCMQWQlaZdaFincproQG+xtjN9E5XC MQ6taqg5dXHIGW98PoIIMwI+TqJdPzhkIAzSIU1J8VuaD7Z0vKN3qYglL44Ca3L/ dQVKDVG8ctMWylsxUqAX53c+sZBs95feurAm1ega80lS1ciSUzLyhixBkpTAXbcM oXwhVsb9zWjZOaJ0M3L7GwSgfINMA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrledvgdduuddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id AC714E46B8; Sun, 31 Mar 2019 13:06:04 -0400 (EDT) From: Thomas Monjalon To: "Zhang, Qi Z" Cc: dev@dpdk.org, "Lu, Wenzhuo" , "Yang, Qiming" , "Stillwell Jr, Paul M" , "Yigit, Ferruh" , cathal.ohare@intel.com, john.mcnamara@intel.com Date: Sun, 31 Mar 2019 19:06:03 +0200 Message-ID: <1570574.eaFxuQL18R@xps> In-Reply-To: <039ED4275CED7440929022BC67E7061153351DC4@SHSMSX103.ccr.corp.intel.com> References: <20190228055650.25237-1-qi.z.zhang@intel.com> <20190325054452.2616-1-qi.z.zhang@intel.com> <039ED4275CED7440929022BC67E7061153351DC4@SHSMSX103.ccr.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v4 00/38] ice share code update. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190331170603.oVYAHgYdtUijQkZCpN0hjfFRqkl05ojNq_7ZzLjyrdI@z> 25/03/2019 08:07, Zhang, Qi Z: > > Sync to latest kernel driver, main changes: > > 1. add DCB/FDIR support. > > 2. add more APIs in switch module. > > 3. code clean and bug fix. > > > > Qi Zhang (38): > > net/ice/base: add switch resource allocation and free > > net/ice/base: improve comments > > net/ice/base: add two helper functions > > net/ice/base: add helper macros > > net/ice/base: allow package copy to be used after resets > > net/ice/base: clean code > > net/ice/base: declare functions as external > > net/ice/base: add more APIs in switch module > > net/ice/base: add VSI queue context framework > > net/ice/base: add APIs to add remove ethertype filter > > net/ice/base: add APIs to get allocated resources > > net/ice/base: add APIs to alloc/free resource counter > > net/ice/base: add APIs to get VSI promiscuous mode > > net/ice/base: add MAC filter with marker and counter > > net/ice/base: add two helper functions for flow management > > net/ice/base: fix minor issues > > net/ice/base: update macros > > net/ice/base: clean code > > net/ice/base: enable VSI queue context > > net/ice/base: ensure only valid bits are set > > net/ice/base: enhance get link status command > > net/ice/base: add RSS key related macro and structures > > net/ice/base: do not write TCAM entries back > > net/ice/base: remove local VSIG allocations > > net/ice/base: fix minor issues > > net/ice/base: update copyright time > > net/ice/base: fix Klockwork analysis reported issues > > net/ice/base: return config error without queue to disable > > net/ice/base: add function to check FW recovery mode > > net/ice/base: change profile id reference counting > > net/ice/base: add DCB support > > net/ice/base: add FDIR support > > net/ice/base: change profile priority for RSS reply > > net/ice/base: fix duplicate resource allocations > > net/ice/base: fix minor issues > > net/ice/base: increase prototol offset size > > net/ice/base: revert the workaround for resource allocation > > net/ice/base: rework on bit ops > > Applied to dpdk-next-net-intel. > > Thanks > Qi 3 commits have the title "fix minor issues", that's a funny performance. When the ice PMD will enter in a serious phase, you should write some real commit titles and explain what are the fixed issues. For DPDK 19.05, I guess it's fine because ice PMD is not going to be really used soon, right?