DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Daniel Kan <dan@nyansa.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] Unable to get RSS to work in testpmd and load balancing question
Date: Fri, 10 Jan 2014 00:11:43 +0100	[thread overview]
Message-ID: <1570706.IYEFmS7tHv@x220> (raw)
In-Reply-To: <6B1399EF-19FC-4493-B9CA-DD872CD728B4@nyansa.com>

Hello,

09/01/2014 10:49, Daniel Kan :
> The problem appears to be that rxmode.mq_mode was never set to ETH_MQ_RX_RSS
> in testpmd.c; it’s initialized to 0.

You're right. Its broken since the commit	"ETH_MQ_RX_NONE should disable RSS":
http://dpdk.org/browse/dpdk/commit/?id=243db2ddee3094a2cb39fdd4b17e26df4e7735e1

> There should probably be a configuration for that, or should be set when
> rxq > 1.

RSS can be configured or disabled with testpmd options or commands.
So it must be fixed in 2 places:
- in app/test-pmd/parameters.c for options
- in app/test-pmd/cmdline.c for commands
When setting rss_hf, mq_mode must be set accordingly.

Note that DCB feature can use mq_mode.

Thanks for the report. Patch is welcome :)
-- 
Thomas

  reply	other threads:[~2014-01-09 23:10 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-08 23:24 Dan Kan
2014-01-09 18:49 ` Daniel Kan
2014-01-09 23:11   ` Thomas Monjalon [this message]
2014-01-10  1:02     ` Dan Kan
2014-01-10  2:07 Choi, Sy Jong
2014-01-10  2:35 ` Daniel Kan
2014-01-10 16:04   ` Michael Quicquaro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1570706.IYEFmS7tHv@x220 \
    --to=thomas.monjalon@6wind.com \
    --cc=dan@nyansa.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).