DPDK patches and discussions
 help / color / mirror / Atom feed
From: Anand Sunkad <anand.sunkad@benisontech.com>
To: Jakub Grajciar <jgrajcia@cisco.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	Vivek Gupta <vivekg@benisontech.com>,
	Thomas Mulamangalath <thomas.mulamangalath@benisontech.com>,
	Anand Sunkad <anand.sunkad@benisontech.com>
Subject: [dpdk-dev] [PATCH] net/memif: add multiple memif data transmission support
Date: Wed, 16 Oct 2019 13:22:10 +0000	[thread overview]
Message-ID: <1571232181-5874-1-git-send-email-anand.sunkad@benisontech.com> (raw)

When Multiple slave/master Memif interfaces are created in single
process data transmission over second connection is not successful.

Issue is because of "mq->in_port" is not initialized with
"dev->data->port_id" in memif_msg_enq_add_ring() and
memif_msg_receive_add_ring() functions, and while transmitting packets
over second connection in eth_memif_tx function it refer "mq->in_port"
which is always zero, and leads to data transmission always in 0th port.

To mitigate the issue,"mq->in_port" is initialized with
"dev->data->port_id" in memif_msg_enq_add_ring() and
memif_msg_receive_add_ring() functions.

Signed-off-by: Anand Sunkad <anand.sunkad@benisontech.com>
---
 drivers/net/memif/memif_socket.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/memif/memif_socket.c b/drivers/net/memif/memif_socket.c
index 0c71f6c..ef8c509 100644
--- a/drivers/net/memif/memif_socket.c
+++ b/drivers/net/memif/memif_socket.c
@@ -322,6 +322,7 @@
 	mq->log2_ring_size = ar->log2_ring_size;
 	mq->region = ar->region;
 	mq->ring_offset = ar->offset;
+	mq->in_port = dev->data->port_id;
 
 	return 0;
 }
@@ -464,6 +465,7 @@
 	ar->log2_ring_size = mq->log2_ring_size;
 	ar->flags = (type == MEMIF_RING_S2M) ? MEMIF_MSG_ADD_RING_FLAG_S2M : 0;
 	ar->private_hdr_size = 0;
+	mq->in_port = dev->data->port_id;
 
 	return 0;
 }
-- 
1.9.1


             reply	other threads:[~2019-10-16 13:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-16 13:22 Anand Sunkad [this message]
2019-10-17 11:28 ` Jakub Grajciar -X (jgrajcia - PANTHEON TECHNOLOGIES at Cisco)
2019-10-17 13:20 ` Anand Sunkad
2019-10-23  8:45   ` Jakub Grajciar -X (jgrajcia - PANTHEON TECHNOLOGIES at Cisco)
2019-10-23 18:11     ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1571232181-5874-1-git-send-email-anand.sunkad@benisontech.com \
    --to=anand.sunkad@benisontech.com \
    --cc=dev@dpdk.org \
    --cc=jgrajcia@cisco.com \
    --cc=thomas.mulamangalath@benisontech.com \
    --cc=vivekg@benisontech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).