From: Nicolas Chautru <nicolas.chautru@intel.com>
To: akhil.goyal@nxp.com, dev@dpdk.org
Cc: ferruh.yigit@intel.com, thomas@monjalon.net,
Nic Chautru <nicolas.chautru@intel.com>,
stable@dpdk.org
Subject: [dpdk-dev] [PATCH v2 2/2] baseband/fpga_lte_fec: fix to polling of MMIO register
Date: Tue, 22 Oct 2019 06:16:17 -0700 [thread overview]
Message-ID: <1571750177-387063-3-git-send-email-nicolas.chautru@intel.com> (raw)
In-Reply-To: <1571750177-387063-1-git-send-email-nicolas.chautru@intel.com>
From: Nic Chautru <nicolas.chautru@intel.com>
Polling of a MMIO register could misreport the actual value
set dynamically in hardware as the variable was not set explicitly
to volatile integer.
Fixes: efd453698c49 ("baseband/fpga_lte_fec: add driver for FEC on FPGA")
Cc: nicolas.chautru@intel.com
Cc: stable@dpdk.org
Signed-off-by: Nic Chautru <nicolas.chautru@intel.com>
---
drivers/baseband/fpga_lte_fec/fpga_lte_fec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/baseband/fpga_lte_fec/fpga_lte_fec.c b/drivers/baseband/fpga_lte_fec/fpga_lte_fec.c
index 2fc7f11..8bd10b4 100644
--- a/drivers/baseband/fpga_lte_fec/fpga_lte_fec.c
+++ b/drivers/baseband/fpga_lte_fec/fpga_lte_fec.c
@@ -889,7 +889,7 @@ struct __rte_cache_aligned fpga_queue {
* completed. If completion flag is not updated within 1ms it is
* considered as a failure.
*/
- while (!(*((uint8_t *)d->flush_queue_status + q->q_idx) & payload)) {
+ while (!(*((volatile uint8_t *)d->flush_queue_status + q->q_idx) & payload)) {
if (counter > timeout) {
rte_bbdev_log(ERR, "FPGA Queue Flush failed for queue %d",
queue_id);
--
1.8.3.1
next prev parent reply other threads:[~2019-10-22 20:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-22 13:16 [dpdk-dev] [PATCH v2 0/2] baseband/fpga_lte_fec: bug fixes from FPGA LTE HW validation Nicolas Chautru
2019-10-22 13:16 ` [dpdk-dev] [PATCH v2 1/2] baseband/fpga_lte_fec: fix probing fatal failure Nicolas Chautru
2019-10-22 13:16 ` Nicolas Chautru [this message]
2019-10-23 13:51 ` [dpdk-dev] [PATCH v2 0/2] baseband/fpga_lte_fec: bug fixes from FPGA LTE HW validation Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1571750177-387063-3-git-send-email-nicolas.chautru@intel.com \
--to=nicolas.chautru@intel.com \
--cc=akhil.goyal@nxp.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).