From: Peng Huang <peng.huang@intel.com>
To: qi.z.zhang@intel.com
Cc: dev@dpdk.org, xiaolong.ye@intel.com, ting.xu@intel.com,
Peng Huang <peng.huang@intel.com>,
stable@dpdk.org
Subject: [dpdk-dev] [PATCH] app/testpmd: fix Tx checksum problem when TSO enabled
Date: Thu, 24 Oct 2019 09:37:34 +0000 [thread overview]
Message-ID: <1571909854-95982-1-git-send-email-peng.huang@intel.com> (raw)
This patch fixed the TX checksum value problem when enabled TSO in
tunnel packets, because outer UDP checksum calculation depend on
the TSO configuration.
depend on patch:
app/testpmd: enable GTP header parse and Tx checksum offload
Fixes: 0f62d63593ed ("app/testpmd: support tunneled TSO in checksum engine")
Cc: stable@dpdk.org
Signed-off-by: Peng Huang <peng.huang@intel.com>
---
app/test-pmd/csumonly.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c
index e1cb7fb..a1775f4 100644
--- a/app/test-pmd/csumonly.c
+++ b/app/test-pmd/csumonly.c
@@ -478,6 +478,9 @@ struct simple_gre_hdr {
if (info->outer_l4_proto != IPPROTO_UDP)
return ol_flags;
+ if (tso_enabled)
+ ol_flags |= PKT_TX_TCP_SEG;
+
/* Skip SW outer UDP checksum generation if HW supports it */
if (tx_offloads & DEV_TX_OFFLOAD_OUTER_UDP_CKSUM) {
ol_flags |= PKT_TX_OUTER_UDP_CKSUM;
--
1.8.3.1
next reply other threads:[~2019-10-24 3:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-24 9:37 Peng Huang [this message]
2019-10-24 11:37 ` Iremonger, Bernard
2019-10-24 18:35 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1571909854-95982-1-git-send-email-peng.huang@intel.com \
--to=peng.huang@intel.com \
--cc=dev@dpdk.org \
--cc=qi.z.zhang@intel.com \
--cc=stable@dpdk.org \
--cc=ting.xu@intel.com \
--cc=xiaolong.ye@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).