From: "Wei Hu (Xavier)" <xavier.huwei@huawei.com>
To: <dev@dpdk.org>
Cc: <ferruh.yigit@intel.com>, <linuxarm@huawei.com>,
<xavier_huwei@163.com>, <xavier.huwei@tom.com>,
<forest.zhouchang@huawei.com>
Subject: [dpdk-dev] [PATCH v2 3/4] net/hns3: fix the return value when firmware timeout
Date: Fri, 25 Oct 2019 20:37:04 +0800 [thread overview]
Message-ID: <1572007025-43391-4-git-send-email-xavier.huwei@huawei.com> (raw)
In-Reply-To: <1572007025-43391-1-git-send-email-xavier.huwei@huawei.com>
From: Hongbo Zheng <zhenghongbo3@huawei.com>
Configuration commands are sent to firmware for processing.
When firmware processing timeout, the corresponding error
code is returned. Considering that it is more reasonable to
use error code -ETIME for timeout error, the error code for
processing timeout is changed from -EBADE to -ETIME.
Fixes: 737f30e1c3ab ("net/hns3: support command interface with firmware")
Signed-off-by: Hongbo Zheng <zhenghongbo3@huawei.com>
Signed-off-by: Wei Hu (Xavier) <xavier.huwei@huawei.com>
---
drivers/net/hns3/hns3_cmd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/hns3/hns3_cmd.c b/drivers/net/hns3/hns3_cmd.c
index 3eebfdd..58776c2 100644
--- a/drivers/net/hns3/hns3_cmd.c
+++ b/drivers/net/hns3/hns3_cmd.c
@@ -359,7 +359,7 @@ static int hns3_cmd_poll_reply(struct hns3_hw *hw)
timeout++;
} while (timeout < hw->cmq.tx_timeout);
hns3_err(hw, "Wait for reply timeout");
- return -EBADE;
+ return -ETIME;
}
/*
--
2.7.4
next prev parent reply other threads:[~2019-10-25 12:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-25 12:37 [dpdk-dev] [PATCH v2 0/4] some fixes for hns3 PMD driver Wei Hu (Xavier)
2019-10-25 12:37 ` [dpdk-dev] [PATCH v2 1/4] net/hns3: fix the statistics problems about Tx/Rx functions Wei Hu (Xavier)
2019-10-25 12:37 ` [dpdk-dev] [PATCH v2 2/4] net/hns3: fix lack of Rx RSS hash in ol flags Wei Hu (Xavier)
2019-10-25 12:37 ` Wei Hu (Xavier) [this message]
2019-10-25 12:37 ` [dpdk-dev] [PATCH v2 4/4] net/hns3: fix FLR reset failure Wei Hu (Xavier)
2019-10-25 15:07 ` [dpdk-dev] [PATCH v2 0/4] some fixes for hns3 PMD driver Ferruh Yigit
2019-10-26 1:03 ` Wei Hu (Xavier)
2019-10-26 1:56 ` Wei Hu (Xavier)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1572007025-43391-4-git-send-email-xavier.huwei@huawei.com \
--to=xavier.huwei@huawei.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=forest.zhouchang@huawei.com \
--cc=linuxarm@huawei.com \
--cc=xavier.huwei@tom.com \
--cc=xavier_huwei@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).