From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wg0-f43.google.com (mail-wg0-f43.google.com [74.125.82.43])
 by dpdk.org (Postfix) with ESMTP id F14F4594C
 for <dev@dpdk.org>; Fri, 18 Apr 2014 00:43:17 +0200 (CEST)
Received: by mail-wg0-f43.google.com with SMTP id x13so995019wgg.2
 for <dev@dpdk.org>; Thu, 17 Apr 2014 15:43:18 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=VQ/d1KoQdeXJtd7qgBkSaPnperVgq+Q7guZIhgiePuQ=;
 b=Oy41m/gE3MMXeCstvNjr5AoYc5n2uhbmByNmG6YncLHRPB/n7Ye/fFsPfC5qrlHIHg
 zQREbiRhdVi2xuQIJxA1AE71tzU057P3hnj5bPHO/jEjyjV2ebv/dT7ZDh+yaQlTWFKu
 iPC0lpn+YURqcOfBGMYO4nW0K2QLaaUXazmcLZlRPwsAQrbj/0r4B7xUeBNyuOBADIxf
 gr3c894mgm5L/QY2mHG6R3jPcb4iqcaF33hnk46ecIQyZu1RDu77ic+NMHBY3nyN+hye
 S+vqE4qeD9nkI6wyIHkNrGfMRi3ySbVZsBOZFqjem7ajfEHJ510hVwoOC7bTzlpPCCWM
 vrqA==
X-Gm-Message-State: ALoCoQkpPJivLhfAz5SKl+tL+D3qEg9uHYdPGyLge6/TicsiEZhkztemptJLWDRxXYr6uWD3ddud
X-Received: by 10.194.220.42 with SMTP id pt10mr3548974wjc.60.1397774598576;
 Thu, 17 Apr 2014 15:43:18 -0700 (PDT)
Received: from xps13.localnet (abo-213-55-68.mts.modulonet.fr. [85.68.55.213])
 by mx.google.com with ESMTPSA id
 ft8sm7342779wib.13.2014.04.17.15.43.16 for <multiple recipients>
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Thu, 17 Apr 2014 15:43:17 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: David Marchand <david.marchand@6wind.com>
Date: Fri, 18 Apr 2014 00:43:16 +0200
Message-ID: <15724496.jrcSWAV12m@xps13>
Organization: 6WIND
User-Agent: KMail/4.12.4 (Linux/3.14.1-1-ARCH; KDE/4.12.4; x86_64; ; )
In-Reply-To: <20140415135754.GC3557@hmsreliant.think-freely.org>
References: <1397569842-12562-1-git-send-email-david.marchand@6wind.com>
 <20140415135754.GC3557@hmsreliant.think-freely.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] eal: check coremask against detected lcores
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 17 Apr 2014 22:43:18 -0000

> > lcores that are set in coremask should be checked against lcores detected
> > on system. This way, we won't need to check them later.
> > 
> > Besides, if specifying an unavailable lcore, we currently panic in
> > eal_thread_loop() because pthread_setaffinity_np fails.
> > So this check will return an error with a more explicit message in
> > eal_parse_coremask().
> > 
> > "EAL: pthread_setaffinity_np failed
> > 
> >  PANIC in eal_thread_loop():
> >  cannot set affinity"
> > 
> > becomes :
> > 
> > "EAL: lcore 4 unavailable
> > 
> >  EAL: invalid coremask"
> > 
> > Signed-off-by: David Marchand <david.marchand@6wind.com>
> 
> Acked-by: Neil Horman <nhorman@tuxdriver.com>

Applied for version 1.6.0r2.

Thanks for this nice usability improvement
-- 
Thomas