* [dpdk-dev] [PATCH] raw/skeleton: fix test raw_attr set get failure
@ 2019-06-11 21:44 Thinh Tran
2019-06-12 5:35 ` Shreyansh Jain
0 siblings, 1 reply; 3+ messages in thread
From: Thinh Tran @ 2019-06-11 21:44 UTC (permalink / raw)
To: dev; +Cc: Thinh Tran
Using memory on the stack instead of on the heap by calling malloc
also avoid memory leak in case of test case failures
Fixes: 88d0e47880ec ("raw/skeleton: fix memory leak on test failure")
Signed-off-by: Thinh Tran <thinhtr@linux.vnet.ibm.com>
---
drivers/raw/skeleton_rawdev/skeleton_rawdev_test.c | 11 +++--------
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/drivers/raw/skeleton_rawdev/skeleton_rawdev_test.c b/drivers/raw/skeleton_rawdev/skeleton_rawdev_test.c
index 359c9e296..3250c2296 100644
--- a/drivers/raw/skeleton_rawdev/skeleton_rawdev_test.c
+++ b/drivers/raw/skeleton_rawdev/skeleton_rawdev_test.c
@@ -274,17 +274,14 @@ static int
test_rawdev_attr_set_get(void)
{
int ret;
- int *dummy_value;
+ int *dummy_value, set_value;
uint64_t ret_value;
/* Set an attribute and fetch it */
ret = rte_rawdev_set_attr(TEST_DEV_ID, "Test1", 100);
RTE_TEST_ASSERT(!ret, "Unable to set an attribute (Test1)");
- dummy_value = malloc(sizeof(int));
- if (!dummy_value)
- RTE_TEST_ASSERT(1, "Unable to allocate memory (dummy_value)");
-
+ dummy_value = &set_value;
*dummy_value = 200;
ret = rte_rawdev_set_attr(TEST_DEV_ID, "Test2", (uintptr_t)dummy_value);
@@ -294,11 +291,9 @@ test_rawdev_attr_set_get(void)
"Attribute (Test1) not set correctly (%" PRIu64 ")",
ret_value);
- free(dummy_value);
-
ret_value = 0;
ret = rte_rawdev_get_attr(TEST_DEV_ID, "Test2", &ret_value);
- RTE_TEST_ASSERT_EQUAL(*((int *)(uintptr_t)ret_value), 200,
+ RTE_TEST_ASSERT_EQUAL(*((int *)(uintptr_t)ret_value), set_value,
"Attribute (Test2) not set correctly (%" PRIu64 ")",
ret_value);
--
2.21.0.windows.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] raw/skeleton: fix test raw_attr set get failure
2019-06-11 21:44 [dpdk-dev] [PATCH] raw/skeleton: fix test raw_attr set get failure Thinh Tran
@ 2019-06-12 5:35 ` Shreyansh Jain
2019-07-01 17:53 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Shreyansh Jain @ 2019-06-12 5:35 UTC (permalink / raw)
To: Thinh Tran, dev
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Thinh Tran
> Sent: Wednesday, June 12, 2019 3:14 AM
> To: dev@dpdk.org
> Cc: Thinh Tran <thinhtr@linux.vnet.ibm.com>
> Subject: [dpdk-dev] [PATCH] raw/skeleton: fix test raw_attr set get failure
>
> Using memory on the stack instead of on the heap by calling malloc
> also avoid memory leak in case of test case failures
>
> Fixes: 88d0e47880ec ("raw/skeleton: fix memory leak on test failure")
>
> Signed-off-by: Thinh Tran <thinhtr@linux.vnet.ibm.com>
> ---
Thanks - I had ignored this issue for quite long now.
Acked-by: Shreyansh Jain <Shreyansh.jain@nxp.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] raw/skeleton: fix test raw_attr set get failure
2019-06-12 5:35 ` Shreyansh Jain
@ 2019-07-01 17:53 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2019-07-01 17:53 UTC (permalink / raw)
To: Thinh Tran; +Cc: dev, Shreyansh Jain
12/06/2019 07:35, Shreyansh Jain:
> > -----Original Message-----
> > From: dev <dev-bounces@dpdk.org> On Behalf Of Thinh Tran
> > Sent: Wednesday, June 12, 2019 3:14 AM
> > To: dev@dpdk.org
> > Cc: Thinh Tran <thinhtr@linux.vnet.ibm.com>
> > Subject: [dpdk-dev] [PATCH] raw/skeleton: fix test raw_attr set get failure
> >
> > Using memory on the stack instead of on the heap by calling malloc
> > also avoid memory leak in case of test case failures
> >
> > Fixes: 88d0e47880ec ("raw/skeleton: fix memory leak on test failure")
Cc: stable@dpdk.org
> > Signed-off-by: Thinh Tran <thinhtr@linux.vnet.ibm.com>
> > ---
>
> Thanks - I had ignored this issue for quite long now.
>
> Acked-by: Shreyansh Jain <Shreyansh.jain@nxp.com>
Applied, thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-07-01 17:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-11 21:44 [dpdk-dev] [PATCH] raw/skeleton: fix test raw_attr set get failure Thinh Tran
2019-06-12 5:35 ` Shreyansh Jain
2019-07-01 17:53 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).