From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 145564C76; Wed, 28 Mar 2018 00:35:59 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 8B01F2112B; Tue, 27 Mar 2018 18:35:58 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 27 Mar 2018 18:35:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=9Tt2++zbYrfn0n5+vrhIHfCpKX RUm+pXIdjtrPvhc9o=; b=PxoCdo5g4jEOokXLDKbP/S0i4Vx3LazHvqF2vt5BC5 o5VnJHoSMiel1peVL/UahVr5CzrovoBvov4vGOECLxnu1QrmDwr4BRQ8dFEZE0dE A3Xv/1lTWsGBdLlfQoht7kLbcRi5VLzTcmVQW3G+MejN1MDx3CEDAHvrq8alGPk5 0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=9Tt2++ zbYrfn0n5+vrhIHfCpKXRUm+pXIdjtrPvhc9o=; b=McGkG1agn5e5akrMDhFGmZ pcvyvNoTJqCnb/NyRSjbD4OMNYjzJiF+2k2qJaUKYhT/+HQzDDvLZN5wLrtgICjl xw6C6RfQoM5DWOq+1CT9+HRCBYjx3O1E/TIPnSKCprGF/WrGeoRF7qBWe47QMS1m SnUEj5zpC+n3615KZw9lAD7jguk8RZwFY8xbOPjXDktJG66has8Iz1YQYk5Pq0U4 Ks3k1bXUD4IbsmITkxgKPdql/eKmV2s1rKPnn4PfWtMDoj+TPIT2BvJLlH1JIu9k NMA4Q6YL98VxeM9xvRkkTTLG6P9x6iFMaCP1L0ifR7whoAmz/UUkxV+3eTivFiYw == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id C1CCE10255; Tue, 27 Mar 2018 18:35:57 -0400 (EDT) From: Thomas Monjalon To: Nachiketa Prachanda Cc: stable@dpdk.org, Jianfeng Tan , dev@dpdk.org, jblunck@infradead.org Date: Wed, 28 Mar 2018 00:35:56 +0200 Message-ID: <1573463.hXvn9TCkJ5@xps> In-Reply-To: <1520873640-24067-1-git-send-email-nprachan@vyatta.att-mail.com> References: <1520873640-24067-1-git-send-email-nprachan@vyatta.att-mail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] vdev: fix name comparison in find_vdev X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Mar 2018 22:35:59 -0000 12/03/2018 17:54, Nachiketa Prachanda: > Use strcmp to compare device names as the strncmp in original code > causes find_vdev to return -EEXIST for names that are prefix > of another. The creation of interfaces fails unpredictably based > on the order of their creation. An easy way hit this bug is to create > eth_vhost1 after eth_vhost11. > > Fixes: dda987315ca2 ("vdev: make virtual bus use its device struct") > Cc: jblunck@infradead.org > Cc: stable@dpdk.org > > Signed-off-by: Nachiketa Prachanda > Acked-by: Jianfeng Tan Applied, thanks