From: Xueming Li <xuemingl@mellanox.com>
To: Anatoly Burakov <anatoly.burakov@intel.com>
Cc: Asaf Penso <asafp@mellanox.com>, dev@dpdk.org, stable@dpdk.org
Subject: [dpdk-dev] [PATCH 1/2] malloc: fix realloc wrong copy size
Date: Tue, 12 Nov 2019 14:50:27 +0000 [thread overview]
Message-ID: <1573570228-15676-1-git-send-email-xuemingl@mellanox.com> (raw)
In rte_realloc, if the old element has pad and need to allocate a new
memory, the padding size was not deducted, so more data was copied to
new data area.
Fixes: af75078fece3 ("first public release")
Cc: stable@dpdk.org
Signed-off-by: Xueming Li <xuemingl@mellanox.com>
---
lib/librte_eal/common/rte_malloc.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/librte_eal/common/rte_malloc.c b/lib/librte_eal/common/rte_malloc.c
index 413e4aa004..d6026a2b17 100644
--- a/lib/librte_eal/common/rte_malloc.c
+++ b/lib/librte_eal/common/rte_malloc.c
@@ -150,7 +150,8 @@ rte_realloc_socket(void *ptr, size_t size, unsigned int align, int socket)
void *new_ptr = rte_malloc_socket(NULL, size, align, socket);
if (new_ptr == NULL)
return NULL;
- const unsigned old_size = elem->size - MALLOC_ELEM_OVERHEAD;
+ /* elem: |pad|data_elem|data|trailer| */
+ const size_t old_size = elem->size - elem->pad - MALLOC_ELEM_OVERHEAD;
rte_memcpy(new_ptr, ptr, old_size < size ? old_size : size);
rte_free(ptr);
--
2.17.1
next reply other threads:[~2019-11-12 14:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-12 14:50 Xueming Li [this message]
2019-11-12 14:50 ` [dpdk-dev] [PATCH 2/2] malloc: fix realloc padded element size Xueming Li
2019-11-14 15:11 ` Burakov, Anatoly
2019-11-19 20:47 ` [dpdk-dev] [dpdk-stable] " David Marchand
2019-11-20 2:12 ` Xueming(Steven) Li
2019-11-20 13:25 ` David Marchand
2019-11-21 12:30 ` Burakov, Anatoly
2019-11-21 12:55 ` Xueming(Steven) Li
2019-11-21 13:15 ` Burakov, Anatoly
2019-11-21 13:17 ` Burakov, Anatoly
2019-11-21 14:11 ` Xueming(Steven) Li
2019-11-14 15:11 ` [dpdk-dev] [PATCH 1/2] malloc: fix realloc wrong copy size Burakov, Anatoly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1573570228-15676-1-git-send-email-xuemingl@mellanox.com \
--to=xuemingl@mellanox.com \
--cc=anatoly.burakov@intel.com \
--cc=asafp@mellanox.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).