From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 19CCC14EC for ; Wed, 10 May 2017 18:13:16 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id BFDDD209CD; Wed, 10 May 2017 12:13:15 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Wed, 10 May 2017 12:13:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=0N4sFIp/GmsFUx6 Lb0yAc16Gv4tkA8dymXP//ALY9hQ=; b=G41FA+9yikZJb+oq5sV3/cIs4Rx2dYa k3ABIdE8lLGWtrB1WV6DehfbeSSk2bEREASMHcSPSdrAdZLSoznWxl4HVhGtqPPP /0l8iYnUoR/PNWuZJNUF/NpTjZM3a8DIjT4bI6r8rg8/U+oqTOwP8DsUdmIaoAmP QB4weME8jGjI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=0N4sFIp/GmsFUx6Lb0yAc16Gv4tkA8dymXP//ALY9hQ=; b=AyGSvLmU mDBG411BJ0slNLoxUJVtScfvsFr8TJas2x/s4MUEaY1STl/vDHPJs6c1p4NC2qcg 3JetUR6utysBgjEzaZu3ma9KCOHFiP+4Ac+FGk7Md5vi2RWw03qB6TCFRsruvGzf G168jBgkmjd1P5myvhmgS1uVzYKrOwzvcATxvAMdGCEYkoVMlXkOak4OpJzx+9SA 5+CQdmfweHyPiBvOw0Cq9Vjfixk+bCaBaQQHX15J7elbmoCCmrjJN/bQE3A1MnTc Wn3K0k8ogm7BysNV7nYyzdIwjNcF0zSgPHD97DMSxk8KPDI/c/4+ZAvJoQNxoFUS QzfLonoBCD3Qqg== X-ME-Sender: X-Sasl-enc: iebpYPJc17ZP+wg+NJkz5VXDdAQHFgLmy3RSxokslHZd 1494432795 Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 78BC27E8B8; Wed, 10 May 2017 12:13:15 -0400 (EDT) From: Thomas Monjalon To: "Mody, Rasesh" Cc: dev@dpdk.org, Dept-Eng DPDK Dev Date: Wed, 10 May 2017 18:13:14 +0200 Message-ID: <1573572.KXZY3xMyNf@xps> In-Reply-To: References: <1494197592-12266-1-git-send-email-rasesh.mody@cavium.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] net/qede: fix RSS table entries for 100G adapter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 May 2017 16:13:16 -0000 08/05/2017 21:03, Mody, Rasesh: > Hi Thomas, > > > From: Rasesh Mody [mailto:rasesh.mody@cavium.com] > > Sent: Sunday, May 07, 2017 3:53 PM > > > > With the change in base APIs the logic for 100G handling needs to be > > adjusted to pass cid values instead for queue ids. The current API works > > assuming its queue id. > > > > Fixes: 69d7ba88f1a1 ("net/qede/base: use L2-handles for RSS configuration") > > This is a *CRITICAL MUST FIX* patch for 100Gb adapters supported by qed/qede on DPDK 17.05. There will be functional and performance issues/regression without this fix on 100Gb adapters. > > Without this change, RSS in 100Gb adapters do not function properly and leads to performance issues. Rx Queue stop command on 100Gb adapter will results in FW exception, where the Rx queue stop request gets stuck in FW and leads to PMD/application error saying failed to stop RXQ 0. > > The issue was introduced by one of the 17.05 base driver patches (net/qede/base: use L2-handles for RSS configuration), which has changed the logic to use queue handles instead of queue ids. However, we missed to make the corresponding changes in 17.05 QEDE for the 100Gb adapter. This patch addresses that by making changes in QEDE to work with queue handles and associate the queues to respective HW functions based on queue handles. > > Please include this fix in 17.05 release. Applied, thanks This patch is big. So I will wait for compilation tests of the night before releasing.