From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0B445A0353; Tue, 12 Nov 2019 22:47:23 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 676DB4C9D; Tue, 12 Nov 2019 22:47:17 +0100 (CET) Received: from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129]) by dpdk.org (Postfix) with ESMTP id 742B24C93 for ; Tue, 12 Nov 2019 22:47:16 +0100 (CET) Received: from Internal Mail-Server by MTLPINE1 (envelope-from matan@mellanox.com) with ESMTPS (AES256-SHA encrypted); 12 Nov 2019 23:47:13 +0200 Received: from pegasus07.mtr.labs.mlnx (pegasus07.mtr.labs.mlnx [10.210.16.112]) by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id xACLlDPv030335; Tue, 12 Nov 2019 23:47:13 +0200 From: Matan Azrad To: dev@dpdk.org Cc: Viacheslav Ovsiienko , dekelp@mellanox.com Date: Tue, 12 Nov 2019 21:47:11 +0000 Message-Id: <1573595231-7992-1-git-send-email-matan@mellanox.com> X-Mailer: git-send-email 1.8.3.1 Subject: [dpdk-dev] [PATCH] net/mlx5: revert default rules amount optimization X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This reverts commit 304ffe576f239e5405228c0feec04b6138d525b7. Commit 304ffe576f23 tried to optimize the amount of the default flow rules and created it only once on top of the PF representor. For each FDB rule, the default port ID to match on is like of the port that triggers the flow. Hence, the single default rule will not be matched on the VF traffic. As a result, all the traffic of the VFs will not match to the jump flow in the root table and will always be forwarded to the representor port. Revert the commit. Fixes: 304ffe576f23 ("net/mlx5: fix condition to create default rule") Cc: dekelp@mellanox.com --- drivers/net/mlx5/mlx5_trigger.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_trigger.c b/drivers/net/mlx5/mlx5_trigger.c index f4dc047..cafab25 100644 --- a/drivers/net/mlx5/mlx5_trigger.c +++ b/drivers/net/mlx5/mlx5_trigger.c @@ -420,7 +420,7 @@ } mlx5_txq_release(dev, i); } - if (priv->config.dv_esw_en && !priv->config.vf && !priv->representor) + if (priv->config.dv_esw_en && !priv->config.vf) if (!mlx5_flow_create_esw_table_zero_flow(dev)) goto error; if (priv->isolated) -- 1.8.3.1