DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] net/mlx5: revert default rules amount optimization
@ 2019-11-12 21:47 Matan Azrad
  2019-11-12 22:00 ` [dpdk-dev] [PATCH v2] " Matan Azrad
  0 siblings, 1 reply; 4+ messages in thread
From: Matan Azrad @ 2019-11-12 21:47 UTC (permalink / raw)
  To: dev; +Cc: Viacheslav Ovsiienko, dekelp

This reverts commit 304ffe576f239e5405228c0feec04b6138d525b7.

Commit 304ffe576f23 tried to optimize the amount of the default flow
rules and created it only once on top of the PF representor.

For each FDB rule, the default port ID to match on is like of the port
that triggers the flow.

Hence, the single default rule will not be matched on the VF traffic.

As a result, all the traffic of the VFs will not match to the jump flow
in the root table and will always be forwarded to the representor port.

Revert the commit.

Fixes: 304ffe576f23 ("net/mlx5: fix condition to create default rule")
Cc: dekelp@mellanox.com
---
 drivers/net/mlx5/mlx5_trigger.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/mlx5/mlx5_trigger.c b/drivers/net/mlx5/mlx5_trigger.c
index f4dc047..cafab25 100644
--- a/drivers/net/mlx5/mlx5_trigger.c
+++ b/drivers/net/mlx5/mlx5_trigger.c
@@ -420,7 +420,7 @@
 		}
 		mlx5_txq_release(dev, i);
 	}
-	if (priv->config.dv_esw_en && !priv->config.vf && !priv->representor)
+	if (priv->config.dv_esw_en && !priv->config.vf)
 		if (!mlx5_flow_create_esw_table_zero_flow(dev))
 			goto error;
 	if (priv->isolated)
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-11-13  9:37 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-12 21:47 [dpdk-dev] [PATCH] net/mlx5: revert default rules amount optimization Matan Azrad
2019-11-12 22:00 ` [dpdk-dev] [PATCH v2] " Matan Azrad
2019-11-13  6:23   ` Slava Ovsiienko
2019-11-13  9:37   ` Raslan Darawsheh

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).