From: Matan Azrad <matan@mellanox.com>
To: dev@dpdk.org
Cc: Viacheslav Ovsiienko <viacheslavo@mellanox.com>, dekelp@mellanox.com
Subject: [dpdk-dev] [PATCH v2] net/mlx5: revert default rules amount optimization
Date: Tue, 12 Nov 2019 22:00:10 +0000 [thread overview]
Message-ID: <1573596010-9467-1-git-send-email-matan@mellanox.com> (raw)
In-Reply-To: <1573595231-7992-1-git-send-email-matan@mellanox.com>
This reverts commit 304ffe576f239e5405228c0feec04b6138d525b7.
It tried to optimize the amount of the default flow
rules and created it only once on top of the PF representor.
For each FDB rule, the default port ID to match on is like of the port
that triggers the flow.
Hence, the single default rule will not be matched on the VF traffic.
As a result, all the traffic of the VFs will not match to the jump flow
in the root table and will always be forwarded to the representor port.
Revert the commit.
Fixes: 304ffe576f23 ("net/mlx5: fix condition to create default rule")
Cc: dekelp@mellanox.com
Signed-off-by: Matan Azrad <matan@mellanox.com>
---
V2:
Fix missing signed-off.
drivers/net/mlx5/mlx5_trigger.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/mlx5/mlx5_trigger.c b/drivers/net/mlx5/mlx5_trigger.c
index f4dc047..cafab25 100644
--- a/drivers/net/mlx5/mlx5_trigger.c
+++ b/drivers/net/mlx5/mlx5_trigger.c
@@ -420,7 +420,7 @@
}
mlx5_txq_release(dev, i);
}
- if (priv->config.dv_esw_en && !priv->config.vf && !priv->representor)
+ if (priv->config.dv_esw_en && !priv->config.vf)
if (!mlx5_flow_create_esw_table_zero_flow(dev))
goto error;
if (priv->isolated)
--
1.8.3.1
next prev parent reply other threads:[~2019-11-12 22:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-12 21:47 [dpdk-dev] [PATCH] " Matan Azrad
2019-11-12 22:00 ` Matan Azrad [this message]
2019-11-13 6:23 ` [dpdk-dev] [PATCH v2] " Slava Ovsiienko
2019-11-13 9:37 ` Raslan Darawsheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1573596010-9467-1-git-send-email-matan@mellanox.com \
--to=matan@mellanox.com \
--cc=dekelp@mellanox.com \
--cc=dev@dpdk.org \
--cc=viacheslavo@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).