* [dpdk-dev] [PATCH] net/mlx5: fix assert in tx inline settings ajustment
@ 2019-11-19 13:13 Viacheslav Ovsiienko
2019-11-19 15:59 ` Raslan Darawsheh
0 siblings, 1 reply; 2+ messages in thread
From: Viacheslav Ovsiienko @ 2019-11-19 13:13 UTC (permalink / raw)
To: dev; +Cc: matan, rasland, orika
Assert condition is fixed to not alert for the case
when multi-packet write is not supported/engaged at all.
Fixes: b53cd86965a1 ("net/mlx5: adjust inline setting for large Tx queue sizes")
Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
---
drivers/net/mlx5/mlx5_txq.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/mlx5/mlx5_txq.c b/drivers/net/mlx5/mlx5_txq.c
index a0d6164..47b1de8 100644
--- a/drivers/net/mlx5/mlx5_txq.c
+++ b/drivers/net/mlx5/mlx5_txq.c
@@ -1210,7 +1210,8 @@ struct mlx5_txq_obj *
assert(txq_ctrl->max_inline_data <= max_inline);
assert(txq_ctrl->txq.inlen_mode <= max_inline);
assert(txq_ctrl->txq.inlen_mode <= txq_ctrl->txq.inlen_send);
- assert(txq_ctrl->txq.inlen_mode <= txq_ctrl->txq.inlen_empw);
+ assert(txq_ctrl->txq.inlen_mode <= txq_ctrl->txq.inlen_empw ||
+ !txq_ctrl->txq.inlen_empw);
return 0;
error:
rte_errno = ENOMEM;
--
1.8.3.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [dpdk-dev] [PATCH] net/mlx5: fix assert in tx inline settings ajustment
2019-11-19 13:13 [dpdk-dev] [PATCH] net/mlx5: fix assert in tx inline settings ajustment Viacheslav Ovsiienko
@ 2019-11-19 15:59 ` Raslan Darawsheh
0 siblings, 0 replies; 2+ messages in thread
From: Raslan Darawsheh @ 2019-11-19 15:59 UTC (permalink / raw)
To: Slava Ovsiienko, dev; +Cc: Matan Azrad, Ori Kam
Hi,
> -----Original Message-----
> From: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
> Sent: Tuesday, November 19, 2019 3:13 PM
> To: dev@dpdk.org
> Cc: Matan Azrad <matan@mellanox.com>; Raslan Darawsheh
> <rasland@mellanox.com>; Ori Kam <orika@mellanox.com>
> Subject: [PATCH] net/mlx5: fix assert in tx inline settings ajustment
>
> Assert condition is fixed to not alert for the case when multi-packet write is
> not supported/engaged at all.
>
> Fixes: b53cd86965a1 ("net/mlx5: adjust inline setting for large Tx queue
> sizes")
>
> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
> ---
> drivers/net/mlx5/mlx5_txq.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/mlx5/mlx5_txq.c b/drivers/net/mlx5/mlx5_txq.c
> index a0d6164..47b1de8 100644
> --- a/drivers/net/mlx5/mlx5_txq.c
> +++ b/drivers/net/mlx5/mlx5_txq.c
> @@ -1210,7 +1210,8 @@ struct mlx5_txq_obj *
> assert(txq_ctrl->max_inline_data <= max_inline);
> assert(txq_ctrl->txq.inlen_mode <= max_inline);
> assert(txq_ctrl->txq.inlen_mode <= txq_ctrl->txq.inlen_send);
> - assert(txq_ctrl->txq.inlen_mode <= txq_ctrl->txq.inlen_empw);
> + assert(txq_ctrl->txq.inlen_mode <= txq_ctrl->txq.inlen_empw ||
> + !txq_ctrl->txq.inlen_empw);
> return 0;
> error:
> rte_errno = ENOMEM;
> --
> 1.8.3.1
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-11-19 15:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-19 13:13 [dpdk-dev] [PATCH] net/mlx5: fix assert in tx inline settings ajustment Viacheslav Ovsiienko
2019-11-19 15:59 ` Raslan Darawsheh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).