From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67]) by dpdk.org (Postfix) with ESMTP id 5CAF0AFD0 for ; Fri, 25 Apr 2014 18:24:46 +0200 (CEST) Received: from was59-1-82-226-113-214.fbx.proxad.net ([82.226.113.214] helo=platinum.localnet) by mail.droids-corp.org with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1Wdix2-0001uW-1H; Fri, 25 Apr 2014 18:26:23 +0200 From: Olivier MATZ To: Neil Horman Date: Fri, 25 Apr 2014 18:24:48 +0200 Message-ID: <1574258.EreYUAxBJs@platinum> Organization: 6WIND User-Agent: KMail/4.11.3 (Linux/3.12.6; KDE/4.11.3; x86_64; ; ) In-Reply-To: <20140425140526.GG14074@hmsreliant.think-freely.org> References: <1398427249-15418-1-git-send-email-olivier.matz@6wind.com> <20140425140526.GG14074@hmsreliant.think-freely.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 0/5] examples: add a new makefile to build all examples X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 25 Apr 2014 16:24:46 -0000 Hi Neil, First, thank you for your reviews. On Friday, April 25, 2014 10:05:26 AM Neil Horman wrote: > > After applying the patches, it is possible to build all examples by doing > > the following: > > user@droids:~/dpdk.org$ cd examples > > user@droids:~/dpdk.org/examples$ make RTE_SDK=${PWD}/.. \ > > RTE_TARGET=x86_64-default-linuxapp-gcc > > What you actually want here is RTE_TARGET=build, as the Makefile looks for > the ${RTE_TARGET}/.config file, it doesn't just parse whatever target file > you specify. > > That begs the bigger point, RTE_TARGET will always be =build, so why not > just add a top level make rule for the examples subdirectory, then RTE_SDK > and RTE_TARGET will just be automatically set. When we compile an example or an external application, RTE_SDK references a binary DPDK, or more precisely a DPDK source workspace that has been compiled with "make install T=my-targets". You're right that RTE_TARGET corresponds to the name of the build directory but the logic is that the name of the directory is the name of the target. To be clearer, the commit log should probably be updated with the following list of commands: user@droids:~/dpdk.org$ make install T=x86_64-default-linuxapp-gcc user@droids:~/dpdk.org$ cd examples user@droids:~/dpdk.org/examples$ make RTE_SDK=${PWD}/.. \ RTE_TARGET=x86_64-default-linuxapp-gcc About adding a top level makefile rule, it's a good idea as it can be documented in "make help", but I wasn't very confident about where to put the output files. I can check if doing something like below is possible or too complex: user@droids:~/dpdk.org$ make install T=x86_64-default-linuxapp-gcc user@droids:~/dpdk.org$ cd x86_64-default-linuxapp-gcc user@droids:~/dpdk.org/x86_64-default-linuxapp-gcc$ make examples # generate examples in $PWD/examples Regards, Olivier