From: Anoob Joseph <anoobj@marvell.com>
To: Marko Kovacevic <marko.kovacevic@intel.com>,
Akhil Goyal <akhil.goyal@nxp.com>,
Pablo de Lara <pablo.de.lara.guarch@intel.com>
Cc: Sucharitha Sarananaga <ssarananaga@marvell.com>,
Jerin Jacob <jerinj@marvell.com>,
Narayana Prasad <pathreya@marvell.com>, <dev@dpdk.org>,
Anoob Joseph <anoobj@marvell.com>
Subject: [dpdk-dev] [PATCH] examples/fips_validation: fix incorrect structure used for AES-GCM
Date: Wed, 27 Nov 2019 10:30:48 +0530 [thread overview]
Message-ID: <1574830848-19137-1-git-send-email-anoobj@marvell.com> (raw)
From: Sucharitha Sarananaga <ssarananaga@marvell.com>
Test vectors for AES-GCM need to be populated by using aead member
and not cipher_auth. Using incorrect member would result in failures
when AES-GCM with non-zero AAD is tried.
Bugzilla ID: 360
Fixes: 4aaad2995e13 ("examples/fips_validation: support GCM parsing")
Signed-off-by: Anoob Joseph <anoobj@marvell.com>
Signed-off-by: Sucharitha Sarananaga <ssarananaga@marvell.com>
---
examples/fips_validation/fips_validation_gcm.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/examples/fips_validation/fips_validation_gcm.c b/examples/fips_validation/fips_validation_gcm.c
index 0509b10..ea48ddf 100644
--- a/examples/fips_validation/fips_validation_gcm.c
+++ b/examples/fips_validation/fips_validation_gcm.c
@@ -34,29 +34,29 @@
#define NEG_TEST_STR "FAIL"
struct fips_test_callback gcm_dec_vectors[] = {
- {KEY_STR, parse_uint8_known_len_hex_str, &vec.cipher_auth.key},
+ {KEY_STR, parse_uint8_known_len_hex_str, &vec.aead.key},
{IV_STR, parse_uint8_known_len_hex_str, &vec.iv},
{CT_STR, parse_uint8_known_len_hex_str, &vec.ct},
- {AAD_STR, parse_uint8_known_len_hex_str, &vec.cipher_auth.aad},
+ {AAD_STR, parse_uint8_known_len_hex_str, &vec.aead.aad},
{TAG_STR, parse_uint8_known_len_hex_str,
- &vec.cipher_auth.digest},
+ &vec.aead.digest},
{NULL, NULL, NULL} /**< end pointer */
};
struct fips_test_callback gcm_interim_vectors[] = {
- {KEYLEN_STR, parser_read_uint32_bit_val, &vec.cipher_auth.key},
+ {KEYLEN_STR, parser_read_uint32_bit_val, &vec.aead.key},
{IVLEN_STR, parser_read_uint32_bit_val, &vec.iv},
{PTLEN_STR, parser_read_uint32_bit_val, &vec.pt},
- {AADLEN_STR, parser_read_uint32_bit_val, &vec.cipher_auth.aad},
+ {AADLEN_STR, parser_read_uint32_bit_val, &vec.aead.aad},
{TAGLEN_STR, parser_read_uint32_bit_val,
- &vec.cipher_auth.digest},
+ &vec.aead.digest},
{NULL, NULL, NULL} /**< end pointer */
};
struct fips_test_callback gcm_enc_vectors[] = {
- {KEY_STR, parse_uint8_known_len_hex_str, &vec.cipher_auth.key},
+ {KEY_STR, parse_uint8_known_len_hex_str, &vec.aead.key},
{IV_STR, parse_uint8_known_len_hex_str, &vec.iv},
{PT_STR, parse_uint8_known_len_hex_str, &vec.pt},
- {AAD_STR, parse_uint8_known_len_hex_str, &vec.cipher_auth.aad},
+ {AAD_STR, parse_uint8_known_len_hex_str, &vec.aead.aad},
{NULL, NULL, NULL} /**< end pointer */
};
--
2.7.4
next reply other threads:[~2019-11-27 5:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-27 5:00 Anoob Joseph [this message]
2019-11-28 15:12 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1574830848-19137-1-git-send-email-anoobj@marvell.com \
--to=anoobj@marvell.com \
--cc=akhil.goyal@nxp.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=marko.kovacevic@intel.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=pathreya@marvell.com \
--cc=ssarananaga@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).