From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 319B04594F; Tue, 10 Sep 2024 07:10:14 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E83F94021F; Tue, 10 Sep 2024 07:10:13 +0200 (CEST) Received: from mail.lysator.liu.se (mail.lysator.liu.se [130.236.254.3]) by mails.dpdk.org (Postfix) with ESMTP id DCB9640151 for ; Tue, 10 Sep 2024 07:10:11 +0200 (CEST) Received: from mail.lysator.liu.se (localhost [127.0.0.1]) by mail.lysator.liu.se (Postfix) with ESMTP id 006D31A136 for ; Tue, 10 Sep 2024 07:10:11 +0200 (CEST) Received: by mail.lysator.liu.se (Postfix, from userid 1004) id E83241A135; Tue, 10 Sep 2024 07:10:10 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on hermod.lysator.liu.se X-Spam-Level: X-Spam-Status: No, score=-1.2 required=5.0 tests=ALL_TRUSTED,AWL, T_SCC_BODY_TEXT_LINE autolearn=disabled version=4.0.0 X-Spam-Score: -1.2 Received: from [192.168.1.86] (h-62-63-215-114.A163.priv.bahnhof.se [62.63.215.114]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.lysator.liu.se (Postfix) with ESMTPSA id B66E11A134; Tue, 10 Sep 2024 07:10:08 +0200 (CEST) Message-ID: <157522d5-36b8-4a0e-95ba-132219f683a8@lysator.liu.se> Date: Tue, 10 Sep 2024 07:10:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 1/6] dpdk: do not force C linkage on include file dependencies To: fengchengwen , =?UTF-8?Q?Mattias_R=C3=B6nnblom?= , dev@dpdk.org Cc: Heng Wang , Stephen Hemminger , Tyler Retzlaff , =?UTF-8?Q?Morten_Br=C3=B8rup?= , Jack Bond-Preston , David Marchand References: <20240812124930.604796-2-mattias.ronnblom@ericsson.com> <20240909145743.697342-1-mattias.ronnblom@ericsson.com> <20240909145743.697342-2-mattias.ronnblom@ericsson.com> <9f430520-3ded-d7bc-42a6-87dd9443dabe@huawei.com> Content-Language: en-US From: =?UTF-8?Q?Mattias_R=C3=B6nnblom?= In-Reply-To: <9f430520-3ded-d7bc-42a6-87dd9443dabe@huawei.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Virus-Scanned: ClamAV using ClamSMTP X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2024-09-10 02:50, fengchengwen wrote: > On 2024/9/9 22:57, Mattias Rönnblom wrote: >> diff --git a/lib/dmadev/rte_dmadev.h b/lib/dmadev/rte_dmadev.h >> index 5474a5281d..11b72b0f2d 100644 >> --- a/lib/dmadev/rte_dmadev.h >> +++ b/lib/dmadev/rte_dmadev.h >> @@ -149,10 +149,6 @@ >> #include >> #include >> >> -#ifdef __cplusplus >> -extern "C" { >> -#endif >> - >> /** Maximum number of devices if rte_dma_dev_max() is not called. */ >> #define RTE_DMADEV_DEFAULT_MAX 64 > > There are many C functions declaration in this region, we should wrap it > by extern "C" {}, so let's keep or add like: > > #include "rte_dmadev_core.h" > #ifdef __cplusplus > } > #endif > > #include "rte_dmadev_trace_fp.h" > > #ifdef __cplusplus > extern "C" { > #endif > OK, will do. Thanks! >> >> @@ -775,6 +771,10 @@ struct rte_dma_sge { >> #include "rte_dmadev_core.h" >> #include "rte_dmadev_trace_fp.h" >> >> +#ifdef __cplusplus >> +extern "C" { >> +#endif >> + >> /**@{@name DMA operation flag >> * @see rte_dma_copy() >> * @see rte_dma_copy_sg()