From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wi0-f176.google.com (mail-wi0-f176.google.com [209.85.212.176]) by dpdk.org (Postfix) with ESMTP id D92E35A55 for ; Fri, 27 Feb 2015 15:42:56 +0100 (CET) Received: by widem10 with SMTP id em10so698824wid.1 for ; Fri, 27 Feb 2015 06:42:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=LDFT/TCrfz59Tp522fY3X7wY0asRnU9nGZljcJGj9UQ=; b=dL+3qzbOnVjtTzrCk5uETdMYaHbXsLJ9A9BCsANlN3ERkDWIkn0XVPjp02hbDmdl+D 198LRquwIssthjiRbv8VlMeqZsuTi3CyWQm8Pqgn/Q1fXMcGKgeMSlDm9A6Oeu0IejiH tvcYrj3Jf1NH1erT/BN5UPfhA2fjHksihjyt02gco3gSp+zcNrWDS+3ZjtQ8NnToyWry 7wL8oJ+9kkWAraSv+R3dguCiT9PWhStvFCYhn64j2FzcRNZHViIX3YyLMABrrL+uYz/l 7p//fzSWabAVdmuOJxCeoc/ZF6x9BWHtxJ1RDvrwMoQxKynxeYpHDdmKx1NMY6OqhFsq 8I1g== X-Gm-Message-State: ALoCoQn41tqDHqiviX33MFby5ahVu6VO5dkIokFgKRWG5nXSJo3ZgwJilQVkaIoODA9y5FLNMm9o X-Received: by 10.180.79.1 with SMTP id f1mr7443623wix.24.1425048176702; Fri, 27 Feb 2015 06:42:56 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id ga8sm3125858wib.6.2015.02.27.06.42.55 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 27 Feb 2015 06:42:55 -0800 (PST) From: Thomas Monjalon To: "Liang, Cunming" Date: Fri, 27 Feb 2015 15:42:17 +0100 Message-ID: <1575268.ERQPa9io3n@xps13> Organization: 6WIND User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; ) In-Reply-To: References: <1424710542-14637-1-git-send-email-danny.zhou@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v6 2/8] eal/linux: add rx queue interrupt FDs to intr handle struct X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Feb 2015 14:42:57 -0000 2015-02-27 11:28, Liang, Cunming: > From: David Marchand [mailto:david.marchand@6wind.com] > Sent: Friday, February 27, 2015 6:33 PM > On Fri, Feb 27, 2015 at 5:56 AM, Cunming Liang > wrote: > > --- a/lib/librte_eal/linuxapp/eal/include/exec-env/rte_interrupts.h= > > +++ b/lib/librte_eal/linuxapp/eal/include/exec-env/rte_interrupts.h= > > @@ -38,6 +38,9 @@ > >=20 > > #ifndef _RTE_LINUXAPP_INTERRUPTS_H_ > > #define _RTE_LINUXAPP_INTERRUPTS_H_ > >=20 > > +#define VFIO_MAX_RXTX_INTR_ID 32 > > +#define VFIO_MAX_QUEUE_ID VFIO_MAX_RXTX_INTR_ID>=20 > This is a little weird to talk about vfio here. > This file is "generic". >=20 > Ok, you will store vfio eventfds here, but vfio is an implementation,= not the abstraction. > [Liang, Cunming] If looking at the rte_intr_hanle_type, it includes U= IO/VFIO_LEGACY/VFIO_MSI/VFIO_MSIX. > I agree, VFIO is an implementation, but the different type combinatio= n is a kind of =E2=80=98abstraction=E2=80=99. > So in rte_intr_handle (like a multiplexing), some specified field for= vfio interrupter mapping, I feel it=E2=80=99s reasonable. >=20 >=20 > -- > David Marchand >=20