DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 5/5] add FILE arguement to debug functions
Date: Fri, 16 May 2014 16:41:55 +0200	[thread overview]
Message-ID: <1575992.oUxJQ8gJcF@xps13> (raw)
In-Reply-To: <C6ECDF3AB251BE4894318F4E45123697592AB70B@IRSMSX101.ger.corp.intel.com>

2014-05-06 12:52, Burakov, Anatoly:
> Hi Stephen,
> 
> > The DPDK dump functions are useful for remote debugging of an
> > applications. But when application runs as a daemon, stdout
> > is typically routed to /dev/null.
> > 
> > Instead change all these functions to take a stdio FILE * handle
> > instead. An application can then use open_memstream() to capture
> > the output.
> 
> Wouldn't it be better to leave old calls as wrappers with the FILE parameter
> defaulting to stdout? That way you wouldn't have to change so much code,
> keep backwards compatibility with old code, and get the additional
> functionality you need.

Refactoring code shouldn't be a problem. We didn't commit for API stability 
yet.

Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com>

  reply	other threads:[~2014-05-16 14:41 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-02 23:42 [dpdk-dev] [PATCH 0/5] Various patches to 1.6.0r2 Stephen Hemminger
2014-05-02 23:42 ` [dpdk-dev] [PATCH 1/5] spelling fixes Stephen Hemminger
2014-05-02 23:42 ` [dpdk-dev] [PATCH 2/5] dont inline string functions Stephen Hemminger
2014-05-02 23:42 ` [dpdk-dev] [PATCH 3/5] mempool: add walk iterator Stephen Hemminger
2014-05-16 12:36   ` Olivier MATZ
2014-05-02 23:42 ` [dpdk-dev] [PATCH 4/5] memzone: add iterator function Stephen Hemminger
2014-05-06  9:17   ` Burakov, Anatoly
2014-05-07 16:33     ` Stephen Hemminger
2014-05-16 12:38   ` Olivier MATZ
2014-05-02 23:42 ` [dpdk-dev] [PATCH 5/5] add FILE arguement to debug functions Stephen Hemminger
2014-05-04 12:20   ` Neil Horman
2014-05-04 20:17     ` Stephen Hemminger
2014-05-05 10:53       ` Neil Horman
2014-05-06  1:55         ` Stephen Hemminger
2014-05-06 11:04           ` Neil Horman
2014-05-06 12:52   ` Burakov, Anatoly
2014-05-16 14:41     ` Thomas Monjalon [this message]
2014-05-16 14:42 ` [dpdk-dev] [PATCH 0/5] Various patches to 1.6.0r2 Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1575992.oUxJQ8gJcF@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).