From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 0366D4CA5
 for <dev@dpdk.org>; Mon, 22 Oct 2018 09:25:21 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id 8A1BE223E5;
 Mon, 22 Oct 2018 03:25:21 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute1.internal (MEProxy); Mon, 22 Oct 2018 03:25:21 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding:content-type; s=mesmtp;
 bh=04cFm+EDdsDliiqWzB/td8S3cxTWa+9vfas9ISa5pw0=; b=R88cdQMTBXOi
 B4uXR+1Xa1z3jiA/C3i9SDFVEPrgyBEQcIq03usJ/tC3xFUc25a0WCcbNPNeoMUB
 BmWMLdvNgFKKfWro22NlDiCP24+ynUu+2jlQ0CVDDNHsu/Oqjum4iyDIdQ/IOyXm
 YAFOZ/tA/hGJuXhRQ667M1fpEOzeZso=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
 :x-sasl-enc; s=fm1; bh=04cFm+EDdsDliiqWzB/td8S3cxTWa+9vfas9ISa5p
 w0=; b=k14OMb+cfGNy6+XDdUiv9y9/6BRdNty4vpPqRmnkan2KfS/91BF2kVBoZ
 +tOre8R/8fkWafpv6WfHPdh/lcYaEM5eK121LhGINJB2oZV8dNi5aSO9mjt+4U1V
 gcghglRYp21rewbUIpvDt86bWYaWK1uRlIWcOsQlRxVZNug+dh4AKDHDyEo6xhA9
 zcsPdU4f7qCAf5PHI+16i+a9A9ft6UBUuF4HTcNrB6i5ffQOq9aOdX1vntr9bn26
 8TON7t/+RfRN+XEYNv+XP5Ym93y0EadLrK2B2vg3w/MlhirU4UBhpferSDcJC89f
 CVVl9N7D7LB+wcYmK8G4N5dEN4avA==
X-ME-Sender: <xms:YXvNW8QHP9t2lUOqqe6unG7uOTjiuQxO54iW-MAoSMFuUR6ZrLKhUQ>
X-ME-Proxy: <xmx:YXvNW-6HP6P9nXi2mxvs3W7wUL6EftESwugslUMAHd_sZDudxWd1hQ>
 <xmx:YXvNW8mbI7iC3hlJyNi9JsSpAkGY0WcQPrYTIonkOLuSn37obDt2VA>
 <xmx:YXvNW1XN3IvvCTbWlzZTsX--oyfQdxYXCavAnbfMvhxiPdCHyfuoNg>
 <xmx:YXvNW-73jCCA_0c2_qfq4izBaXBhbm_R0yUTzTldNsDmXkrxPCe5mQ>
 <xmx:YXvNWwKvquQWNgMgPLDoYysYO7b7n3-CPHt58B0x_j0xQtNsclmDHA>
 <xmx:YXvNWwZtuh7Yz1scKK0VZvB2jFgciAZvTzDS0CCL_8qtkPfe-wkVug>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 7127CE421C;
 Mon, 22 Oct 2018 03:25:20 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Qi Zhang <qi.z.zhang@intel.com>
Cc: dev@dpdk.org, gaetan.rivet@6wind.com
Date: Mon, 22 Oct 2018 09:25:22 +0200
Message-ID: <1576298.HKmtsfqzoT@xps>
In-Reply-To: <20181022054932.39052-1-qi.z.zhang@intel.com>
References: <20181022054932.39052-1-qi.z.zhang@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH] eal: fix floating device argument pointer
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 22 Oct 2018 07:25:22 -0000

22/10/2018 07:49, Qi Zhang:
> After we insert a devargs into devargs_list, following bus->scan may
> destroy it due to another rte_devargs_insert. Its better not to use
> a devargs pointer after it has been inserted.

I think the problem is in:

rte_devargs_insert(struct rte_devargs *da)
{
    int ret;

    ret = rte_devargs_remove(da);                                                                    
    if (ret < 0)
        return ret;
    TAILQ_INSERT_TAIL(&devargs_list, da, next);
    return 0;
}

We insert a structure which is freed!

See http://git.dpdk.org/dpdk/commit/?id=55744d83d525

Gaetan, what can be the fix?