From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 90DD4A04B3; Mon, 27 Jan 2020 11:31:11 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E724A1BF7B; Mon, 27 Jan 2020 11:31:04 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 384291BF75 for ; Mon, 27 Jan 2020 11:31:03 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Jan 2020 02:31:02 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,369,1574150400"; d="scan'208";a="221694723" Received: from silpixa00393944.ir.intel.com ([10.237.223.184]) by orsmga008.jf.intel.com with ESMTP; 27 Jan 2020 02:31:01 -0800 From: Hariprasad Govindharajan To: Wenzhuo Lu , Jingjing Wu , Bernard Iremonger Cc: dev@dpdk.org, Hariprasad Govindharajan Date: Mon, 27 Jan 2020 10:30:52 +0000 Message-Id: <1580121053-26083-2-git-send-email-hariprasad.govindharajan@intel.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1580121053-26083-1-git-send-email-hariprasad.govindharajan@intel.com> References: <1580121053-26083-1-git-send-email-hariprasad.govindharajan@intel.com> Subject: [dpdk-dev] [PATCH 1/2] app/testpmd: add portlist option to the testpmd X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" In current version, we are setting the ports using portmask. With portmask, we can use only upto 64 ports. This portlist option enables the user to use more than 64 ports. Now we can specify the ports in 2 different ways - Using portmask (-p [0x]nnn): mask must be in hex format - Using portlist in the following format --portlist [-p2][,p3[-p4],...] --portmask 0x2 is same as --portlist 1 --portmask 0x3 is same as --portlist 0-1 Signed-off-by: Hariprasad Govindharajan --- app/test-pmd/config.c | 25 +++++++++++++++++++++++++ app/test-pmd/parameters.c | 5 +++++ app/test-pmd/testpmd.h | 3 +++ 3 files changed, 33 insertions(+) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index 9669cbd..49662cf 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c @@ -2588,6 +2588,31 @@ set_fwd_ports_list(unsigned int *portlist, unsigned int nb_pt) } void +parse_fwd_portlist(const char *portlist) +{ + unsigned int portcount = 0; + int portindex[RTE_MAX_ETHPORTS]; + unsigned int ports[RTE_MAX_ETHPORTS]; + unsigned int idx; + /* + * eal_parse_portlist() will mark the portindex array + * with -1 if the port is not listed and with a positive value + * for the listed ports. however, the function set_fwd_ports_list() + * requires a list of portids' so we use 2 arrays to do the + * conversion between 2 formats. + */ + if (eal_parse_optionlist(portlist, portindex, RTE_MAX_ETHPORTS) < 0) + rte_exit(EXIT_FAILURE, "Invalid fwd port list\n"); + + RTE_ETH_FOREACH_DEV(idx) { + if (portindex[idx] != -1) + ports[portcount++] = idx; + } + + set_fwd_ports_list(ports, portcount); +} + +void set_fwd_ports_mask(uint64_t portmask) { unsigned int portlist[64]; diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c index 6340104..404dba2 100644 --- a/app/test-pmd/parameters.c +++ b/app/test-pmd/parameters.c @@ -57,6 +57,7 @@ usage(char* progname) "[--help|-h] | [--auto-start|-a] | [" "--tx-first | --stats-period=PERIOD | " "--coremask=COREMASK --portmask=PORTMASK --numa " + "--portlist=PORTLIST " "--mbuf-size= | --total-num-mbufs= | " "--nb-cores= | --nb-ports= | " #ifdef RTE_LIBRTE_CMDLINE @@ -92,6 +93,7 @@ usage(char* progname) "packet forwarding.\n"); printf(" --portmask=PORTMASK: hexadecimal bitmask of ports used " "by the packet forwarding test.\n"); + printf(" --portlist=PORTLIST: list of forwarding ports\n"); printf(" --numa: enable NUMA-aware allocation of RX/TX rings and of " "RX memory buffers (mbufs).\n"); printf(" --port-numa-config=(port,socket)[,(port,socket)]: " @@ -587,6 +589,7 @@ launch_args_parse(int argc, char** argv) { "nb-ports", 1, 0, 0 }, { "coremask", 1, 0, 0 }, { "portmask", 1, 0, 0 }, + { "portlist", 1, 0, 0 }, { "numa", 0, 0, 0 }, { "no-numa", 0, 0, 0 }, { "mp-anon", 0, 0, 0 }, @@ -825,6 +828,8 @@ launch_args_parse(int argc, char** argv) parse_fwd_coremask(optarg); if (!strcmp(lgopts[opt_idx].name, "portmask")) parse_fwd_portmask(optarg); + if (!strcmp(lgopts[opt_idx].name, "portlist")) + parse_fwd_portlist(optarg); if (!strcmp(lgopts[opt_idx].name, "no-numa")) numa_support = 0; if (!strcmp(lgopts[opt_idx].name, "numa")) diff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h index 3dd5fc7..33ef3e2 100644 --- a/app/test-pmd/testpmd.h +++ b/app/test-pmd/testpmd.h @@ -614,6 +614,9 @@ lcore_num(void) rte_panic("lcore_id of current thread not found in fwd_lcores_cpuids\n"); } +void +parse_fwd_portlist(const char *port); + static inline struct fwd_lcore * current_fwd_lcore(void) { -- 2.7.4