* [dpdk-dev] [PATCH] net/mlx5: fix the blocker for push VLAN in Rx path
@ 2020-02-11 13:20 Wisam Jaddo
2020-02-12 12:52 ` Raslan Darawsheh
0 siblings, 1 reply; 2+ messages in thread
From: Wisam Jaddo @ 2020-02-11 13:20 UTC (permalink / raw)
To: matan, viacheslavo, rasland; +Cc: dev, dekelp
The blocker should take FDB into consideration, since FDB all directions
have transfer ingress in it.
Fixes: 55060e62e4d2 ("net/mlx5: block push VLAN action on Rx")
Cc: dekelp@mellanox.com
Signed-off-by: Wisam Jaddo <wisamm@mellanox.com>
---
drivers/net/mlx5/mlx5_flow_dv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c
index e71b3b5..c986f25 100644
--- a/drivers/net/mlx5/mlx5_flow_dv.c
+++ b/drivers/net/mlx5/mlx5_flow_dv.c
@@ -1746,7 +1746,7 @@ flow_dv_validate_action_push_vlan(uint64_t action_flags,
{
const struct rte_flow_action_of_push_vlan *push_vlan = action->conf;
- if (attr->ingress)
+ if (!attr->transfer && attr->ingress)
return rte_flow_error_set(error, ENOTSUP,
RTE_FLOW_ERROR_TYPE_ATTR_INGRESS,
NULL,
--
2.7.4
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [dpdk-dev] [PATCH] net/mlx5: fix the blocker for push VLAN in Rx path
2020-02-11 13:20 [dpdk-dev] [PATCH] net/mlx5: fix the blocker for push VLAN in Rx path Wisam Jaddo
@ 2020-02-12 12:52 ` Raslan Darawsheh
0 siblings, 0 replies; 2+ messages in thread
From: Raslan Darawsheh @ 2020-02-12 12:52 UTC (permalink / raw)
To: Wisam Monther, Matan Azrad, Slava Ovsiienko; +Cc: dev, Dekel Peled, stable
Hi,
> -----Original Message-----
> From: Wisam Monther <wisamm@mellanox.com>
> Sent: Tuesday, February 11, 2020 3:20 PM
> To: Matan Azrad <matan@mellanox.com>; Slava Ovsiienko
> <viacheslavo@mellanox.com>; Raslan Darawsheh <rasland@mellanox.com>
> Cc: dev@dpdk.org; Dekel Peled <dekelp@mellanox.com>
> Subject: [PATCH] net/mlx5: fix the blocker for push VLAN in Rx path
>
> The blocker should take FDB into consideration, since FDB all directions
> have transfer ingress in it.
>
> Fixes: 55060e62e4d2 ("net/mlx5: block push VLAN action on Rx")
> Cc: dekelp@mellanox.com
Removed Cc: Dekel,
Added Cc: stable@dpdk.org
>
> Signed-off-by: Wisam Jaddo <wisamm@mellanox.com>
Acked-by: Raslan Darawsheh <rasland@mellanox.com>
> ---
> drivers/net/mlx5/mlx5_flow_dv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/mlx5/mlx5_flow_dv.c
> b/drivers/net/mlx5/mlx5_flow_dv.c
> index e71b3b5..c986f25 100644
> --- a/drivers/net/mlx5/mlx5_flow_dv.c
> +++ b/drivers/net/mlx5/mlx5_flow_dv.c
> @@ -1746,7 +1746,7 @@ flow_dv_validate_action_push_vlan(uint64_t
> action_flags,
> {
> const struct rte_flow_action_of_push_vlan *push_vlan = action-
> >conf;
>
> - if (attr->ingress)
> + if (!attr->transfer && attr->ingress)
> return rte_flow_error_set(error, ENOTSUP,
>
> RTE_FLOW_ERROR_TYPE_ATTR_INGRESS,
> NULL,
> --
> 2.7.4
Patch applied to next-net-mlx,
Kindest regards
Raslan Darawsheh
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-02-12 12:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-11 13:20 [dpdk-dev] [PATCH] net/mlx5: fix the blocker for push VLAN in Rx path Wisam Jaddo
2020-02-12 12:52 ` Raslan Darawsheh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).