From: Beilei Xing <beilei.xing@intel.com>
To: dev@dpdk.org, qi.z.zhang@intel.com
Subject: [dpdk-dev] [PATCH] net/i40e: fix unchecked return value
Date: Wed, 12 Feb 2020 03:02:00 +0800 [thread overview]
Message-ID: <1581447720-29099-1-git-send-email-beilei.xing@intel.com> (raw)
Check the return value of the i40e_xmit_cleanup function.
Coverity issue: 353617
Fixes: 4861cde46116 ("i40e: new poll mode driver")
Signed-off-by: Beilei Xing <beilei.xing@intel.com>
---
drivers/net/i40e/i40e_rxtx.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c
index fd1ae80..f43fc0f 100644
--- a/drivers/net/i40e/i40e_rxtx.c
+++ b/drivers/net/i40e/i40e_rxtx.c
@@ -1038,8 +1038,9 @@ i40e_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)
txe = &sw_ring[tx_id];
/* Check if the descriptor ring needs to be cleaned. */
- if (txq->nb_tx_free < txq->tx_free_thresh)
- i40e_xmit_cleanup(txq);
+ if ((txq->nb_tx_free < txq->tx_free_thresh) &&
+ (i40e_xmit_cleanup(txq) != 0))
+ return 0;
for (nb_tx = 0; nb_tx < nb_pkts; nb_tx++) {
td_cmd = 0;
--
2.7.4
next reply other threads:[~2020-02-11 10:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-11 19:02 Beilei Xing [this message]
2020-02-11 11:42 ` Bruce Richardson
2020-02-12 2:33 ` Xing, Beilei
2020-02-12 12:36 ` [dpdk-dev] [PATCH v2] " Beilei Xing
2020-02-14 9:45 ` Ye Xiaolong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1581447720-29099-1-git-send-email-beilei.xing@intel.com \
--to=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=qi.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).