From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0D14EA051C; Tue, 11 Feb 2020 11:10:18 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 444102B89; Tue, 11 Feb 2020 11:10:18 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 5740D293C for ; Tue, 11 Feb 2020 11:10:16 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Feb 2020 02:10:15 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,428,1574150400"; d="scan'208";a="433635999" Received: from npg-dpdk-beilei-3.sh.intel.com ([10.67.110.206]) by fmsmga006.fm.intel.com with ESMTP; 11 Feb 2020 02:10:14 -0800 From: Beilei Xing To: dev@dpdk.org, qi.z.zhang@intel.com Date: Wed, 12 Feb 2020 03:02:00 +0800 Message-Id: <1581447720-29099-1-git-send-email-beilei.xing@intel.com> X-Mailer: git-send-email 2.7.4 Subject: [dpdk-dev] [PATCH] net/i40e: fix unchecked return value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Check the return value of the i40e_xmit_cleanup function. Coverity issue: 353617 Fixes: 4861cde46116 ("i40e: new poll mode driver") Signed-off-by: Beilei Xing --- drivers/net/i40e/i40e_rxtx.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c index fd1ae80..f43fc0f 100644 --- a/drivers/net/i40e/i40e_rxtx.c +++ b/drivers/net/i40e/i40e_rxtx.c @@ -1038,8 +1038,9 @@ i40e_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts) txe = &sw_ring[tx_id]; /* Check if the descriptor ring needs to be cleaned. */ - if (txq->nb_tx_free < txq->tx_free_thresh) - i40e_xmit_cleanup(txq); + if ((txq->nb_tx_free < txq->tx_free_thresh) && + (i40e_xmit_cleanup(txq) != 0)) + return 0; for (nb_tx = 0; nb_tx < nb_pkts; nb_tx++) { td_cmd = 0; -- 2.7.4