From: Anoob Joseph <anoobj@marvell.com>
To: Marko Kovacevic <marko.kovacevic@intel.com>,
Akhil Goyal <akhil.goyal@nxp.com>,
David Marchand <david.marchand@redhat.com>
Cc: Anoob Joseph <anoobj@marvell.com>,
Fan Zhang <roy.fan.zhang@intel.com>,
Narayana Prasad <pathreya@marvell.com>, <dev@dpdk.org>
Subject: [dpdk-dev] [PATCH] examples/fips_validation: fix incorrect CT length string
Date: Tue, 18 Feb 2020 15:14:35 +0530 [thread overview]
Message-ID: <1582019075-7932-1-git-send-email-anoobj@marvell.com> (raw)
The NIST test vectors use the string 'PTlen' to denote text lengths
in case of encrypt & decrypt operations. So the same string need to be used
while parsing PT and CT.
Fixes: 12f826533ff7 ("examples/fips_validation: fix incorrect string for CT length")
Signed-off-by: Anoob Joseph <anoobj@marvell.com>
---
examples/fips_validation/fips_validation_gcm.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/examples/fips_validation/fips_validation_gcm.c b/examples/fips_validation/fips_validation_gcm.c
index bc2d37d..47576e9 100644
--- a/examples/fips_validation/fips_validation_gcm.c
+++ b/examples/fips_validation/fips_validation_gcm.c
@@ -19,7 +19,6 @@
#define PTLEN_STR "PTlen = "
#define AADLEN_STR "AADlen = "
#define TAGLEN_STR "Taglen = "
-#define CTLEN_STR "CTlen = "
#define COUNT_STR "Count = "
#define KEY_STR "Key = "
@@ -47,7 +46,10 @@ struct fips_test_callback gcm_interim_vectors[] = {
{KEYLEN_STR, parser_read_uint32_bit_val, &vec.aead.key},
{IVLEN_STR, parser_read_uint32_bit_val, &vec.iv},
{PTLEN_STR, parser_read_uint32_bit_val, &vec.pt},
- {CTLEN_STR, parser_read_uint32_bit_val, &vec.ct},
+ {PTLEN_STR, parser_read_uint32_bit_val, &vec.ct},
+ /**< The NIST test vectors use 'PTlen' to denote input text
+ * length in case of decrypt & encrypt operations.
+ */
{AADLEN_STR, parser_read_uint32_bit_val, &vec.aead.aad},
{TAGLEN_STR, parser_read_uint32_bit_val,
&vec.aead.digest},
--
2.7.4
next reply other threads:[~2020-02-18 9:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-18 9:44 Anoob Joseph [this message]
2020-02-18 10:31 ` [dpdk-dev] [PATCH v2] examples/fips_validation: fix incorrect string for CT length Anoob Joseph
2020-02-19 10:22 ` Anoob Joseph
2020-02-20 10:15 ` Akhil Goyal
2020-02-20 10:19 ` David Marchand
2020-02-20 15:48 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1582019075-7932-1-git-send-email-anoobj@marvell.com \
--to=anoobj@marvell.com \
--cc=akhil.goyal@nxp.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=marko.kovacevic@intel.com \
--cc=pathreya@marvell.com \
--cc=roy.fan.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).