From: Wisam Jaddo <wisamm@mellanox.com>
To: wenzhuo.lu@intel.com, dev@dpdk.org, rasland@mellanox.com,
matan@mellanox.com
Cc: mukawa@igel.co.jp, stable@dpdk.org
Subject: [dpdk-dev] [PATCH] app/testpmd: fix identifier size for port attach
Date: Wed, 19 Feb 2020 18:47:30 +0200 [thread overview]
Message-ID: <1582130850-6958-1-git-send-email-wisamm@mellanox.com> (raw)
Identifier for new port may contain white list options,
and white list options will not fit into 128 from STR_TOKEN_SIZE,
instead having 4096 char from STR_MULTI_TOKEN_SIZE will provide
better and more options
Fixes: edab33b1c01d ("app/testpmd: support port hotplug")
Cc: mukawa@igel.co.jp
Cc: stable@dpdk.org
Signed-off-by: Wisam Jaddo <wisamm@mellanox.com>
---
app/test-pmd/cmdline.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index 38b6d80..a037a55 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -1446,7 +1446,7 @@ cmdline_parse_inst_t cmd_set_port_setup_on = {
struct cmd_operate_attach_port_result {
cmdline_fixed_string_t port;
cmdline_fixed_string_t keyword;
- cmdline_fixed_string_t identifier;
+ cmdline_multi_string_t identifier;
};
static void cmd_operate_attach_port_parsed(void *parsed_result,
@@ -1469,7 +1469,7 @@ cmdline_parse_token_string_t cmd_operate_attach_port_keyword =
keyword, "attach");
cmdline_parse_token_string_t cmd_operate_attach_port_identifier =
TOKEN_STRING_INITIALIZER(struct cmd_operate_attach_port_result,
- identifier, NULL);
+ identifier, TOKEN_STRING_MULTI);
cmdline_parse_inst_t cmd_operate_attach_port = {
.f = cmd_operate_attach_port_parsed,
--
2.7.4
next reply other threads:[~2020-02-19 16:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-19 16:47 Wisam Jaddo [this message]
2020-02-20 10:03 ` Iremonger, Bernard
2020-02-20 14:18 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2020-02-20 12:28 ` Ferruh Yigit
2020-02-20 12:32 ` Wisam Monther
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1582130850-6958-1-git-send-email-wisamm@mellanox.com \
--to=wisamm@mellanox.com \
--cc=dev@dpdk.org \
--cc=matan@mellanox.com \
--cc=mukawa@igel.co.jp \
--cc=rasland@mellanox.com \
--cc=stable@dpdk.org \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).