From: Hariprasad Govindharajan <hariprasad.govindharajan@intel.com>
To: Wenzhuo Lu <wenzhuo.lu@intel.com>,
Jingjing Wu <jingjing.wu@intel.com>,
Bernard Iremonger <bernard.iremonger@intel.com>
Cc: dev@dpdk.org, ferruh.yigit@intel.com, stephen@networkplumber.org,
david.marchand@redhat.com,
Hariprasad Govindharajan <hariprasad.govindharajan@intel.com>
Subject: [dpdk-dev] [PATCH v3] app/testpmd: fix return value in portlist parser
Date: Thu, 20 Feb 2020 17:39:03 +0000 [thread overview]
Message-ID: <1582220343-22149-1-git-send-email-hariprasad.govindharajan@intel.com> (raw)
In-Reply-To: <1582205191-14105-1-git-send-email-hariprasad.govindharajan@intel.com>
The function parse_port_list() is designed to return
unsigned int value. After sanitizing the inputs,
it is returning -1. Changed it to return 0.
Fixes: 2df00d562d20 ("app/testpmd: add --portlist option")
Cc: hariprasad.govindharajan@intel.com
Signed-off-by: Hariprasad Govindharajan <hariprasad.govindharajan@intel.com>
---
v3:
corrected the documentation comments.
updated the comments on return values.
v2:
modified the head line in the patch
---
app/test-pmd/config.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index 9d95202..e9b89c4 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c
@@ -2616,9 +2616,6 @@ set_fwd_ports_list(unsigned int *portlist, unsigned int nb_pt)
* If the user wants to use only the ports 1,2 then the input
* is 1,2.
* valid characters are '-' and ','
- * invalid chars like '.' or '#' will result in
- * EAL: Error - exiting with code: 1
- * Cause: Invalid fwd port list
* @param[out] values
* This array will be filled with a list of port IDs
* based on the user input
@@ -2630,7 +2627,8 @@ set_fwd_ports_list(unsigned int *portlist, unsigned int nb_pt)
* 1) Number of elements in the values array
* 2) Maximum value of each element in the values array
* @return
- * -returns total count of parsed port IDs
+ * On success, returns total count of parsed port IDs
+ * On failure, returns 0
*/
static unsigned int
parse_port_list(const char *list, unsigned int *values, unsigned int maxsize)
@@ -2642,7 +2640,7 @@ parse_port_list(const char *list, unsigned int *values, unsigned int maxsize)
unsigned int marked[maxsize];
if (list == NULL || values == NULL)
- return -1;
+ return 0;
for (i = 0; i < (int)maxsize; i++)
marked[i] = 0;
--
2.7.4
next prev parent reply other threads:[~2020-02-20 17:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-20 13:26 [dpdk-dev] [PATCH] app/testpmd: fix wrong return value in parse_port_list Hariprasad Govindharajan
2020-02-20 15:29 ` Iremonger, Bernard
2020-02-20 15:43 ` [dpdk-dev] [PATCH v2] app/testpmd: fix return value in portlist parser Hariprasad Govindharajan
2020-02-20 15:46 ` Govindharajan, Hariprasad
2020-02-20 17:01 ` Ferruh Yigit
2020-02-20 17:39 ` Hariprasad Govindharajan [this message]
2020-02-20 20:41 ` [dpdk-dev] [PATCH v3] " Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1582220343-22149-1-git-send-email-hariprasad.govindharajan@intel.com \
--to=hariprasad.govindharajan@intel.com \
--cc=bernard.iremonger@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jingjing.wu@intel.com \
--cc=stephen@networkplumber.org \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).