From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id BC7817D4A for ; Wed, 19 Sep 2018 19:43:59 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 689BC21F79; Wed, 19 Sep 2018 13:43:59 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 19 Sep 2018 13:43:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= mesmtp; bh=DogbMR4BBx6lnUZeAP8i1oxP8KMoIWkV9CvNE6HWa10=; b=AB/CV LkWMxx15KrnCXGoXYbCaRFkTmr9UVzFQvp5oqz9AvjqAG3chZlTrO2p2Ag8iiO5d 5//C6Kf/U5hLEUkN41eoa453wQgJlzYu93xdU4Jlc8AUGbdr4W344lw7dzgIJdK3 cHsZuoVZ6F1z7mo7PrwLWSJX9aOhip8zgCPaSY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:message-id:mime-version:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm3; bh=DogbMR4BBx6lnUZeAP8i1oxP8KMoI WkV9CvNE6HWa10=; b=pHuEOMmkxkxlJrvI9RDNHQP1t6WQUJvj9ISvXrL0TeNWb ojZGafm3BrtYs+m8TojiEk1LcHTn88804D4eqE5od62ECDurboL2NhDzsMYuE8hA /GvW2pq2hSzZ7aDfmZS6qaB791We8C4j1mbGCa+ZRwv3VRh5lGUqa/1VoCtGrbN+ GGP0OfnBQ/WZgQXYb3W5zXQbbAsLrdn/rSUk1JQqbDw5BhFJlnxB/4QftfurTkWY ey4xbUBoJ7UOWt/VAPUGjpGUKeDpLwDzwKJGtRuYG/vXmEQwMr0Tigp6sR8Gsxp8 ZpjL/rJnqQX3gcE0/PwzYIwc3SHy4nZm5Ahz3TMjw== X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 7301DE47C6; Wed, 19 Sep 2018 13:43:58 -0400 (EDT) From: Thomas Monjalon To: Neil Horman Cc: dev@dpdk.org Date: Wed, 19 Sep 2018 19:43:57 +0200 Message-ID: <1582481.Q53MnriLgg@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: [dpdk-dev] false positive in check-symbol-change.sh tool X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Sep 2018 17:44:00 -0000 Hi Neil, I think I've discovered a false positive with the script devtools/check-symbol-change.sh When checking the patch http://patches.dpdk.org/patch/40601/, which is adding an experimental section with a symbol in it, we can see this message: ERROR: symbol rte_frag_table_del_expired_entries is added in a section other than the EXPERIMENTAL section of the version map The code raising this error is below: if [ "$secname" != "EXPERIMENTAL" ] then # Symbols that are getting added in a section # other than the experimental section # to be moving from an already supported # section or its a violation grep -q \ "$mname $symname [^EXPERIMENTAL] del" "$mapdb" if [ $? -ne 0 ] then echo -n "ERROR: symbol $symname " echo -n "is added in a section " echo -n "other than the EXPERIMENTAL " echo "section of the version map" ret=1 fi fi After a quick check, I see two strange things: 1/ $secname is "+EXPERIMENTAL" in this case This is probably the root cause of this false positive. 2/ The grep pattern is probably not what you want. The regex [^EXPERIMENTAL] means "a character which is none of the letters in EXPERIMENTAL". Hope it can help you (or others) to fix some issues. Thanks