From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A73FDA0573; Thu, 5 Mar 2020 16:49:04 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0396E2C02; Thu, 5 Mar 2020 16:49:04 +0100 (CET) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 85A382BE3; Thu, 5 Mar 2020 16:49:02 +0100 (CET) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us3.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 497EE6C008A; Thu, 5 Mar 2020 15:49:01 +0000 (UTC) Received: from ukex01.SolarFlarecom.com (10.17.10.4) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 5 Mar 2020 15:48:57 +0000 Received: from opal.uk.solarflarecom.com (10.17.10.1) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Thu, 5 Mar 2020 15:48:57 +0000 Received: from ukv-loginhost.uk.solarflarecom.com (ukv-loginhost.uk.solarflarecom.com [10.17.10.39]) by opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id 025Fmvno018243; Thu, 5 Mar 2020 15:48:57 GMT Received: from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1]) by ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id 2BF2D1611DB; Thu, 5 Mar 2020 15:48:57 +0000 (GMT) From: Andrew Rybchenko To: CC: Igor Romanov , Date: Thu, 5 Mar 2020 15:48:55 +0000 Message-ID: <1583423335-15020-1-git-send-email-arybchenko@solarflare.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1020-25270.003 X-TM-AS-Result: No-2.727100-8.000000-10 X-TMASE-MatchedRID: t0V6V3Db6XC5AXX9wquN8ee+D9J+pd39QLvQNAwp+a/RLEyE6G4DROPd pDLFu49iyERIxmf95i+mcFuKGELrlgSUDOeIjmYUHPYwOJi6PLl6i696PjRPiFjBUeMsjed6QBz oPKhLasjmlKOTIZXkNp6w9d/7Z25jgb1XSSpDa5Dm96eHJyFxjS3ExqBs3388HApIKLQpe4Rb2h LMwC10suLzNWBegCW2wgn7iDBesS1YF3qW3Je6+0b8JGoS2DChC5mLHhq61m9nJwXwtcNw0aSI+ NS4H6A4aymSO0QtWtfBnp1d4XLEcaWscuoMQaEqXkXgmj0N3c2FTQ6t7iYdG71NuKS30BZnQIFI ZLtsgG0DUH+nVLNyiCsqIP9TxvtJo1s8kG68tot+3BndfXUhXQ== X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10-2.727100-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1020-25270.003 X-MDID: 1583423342-bDSI2h1Fd76w Subject: [dpdk-dev] [PATCH] net/sfc: fix Rx queue start failure path X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Igor Romanov Call correct cleanup operations on failure in Rx queue start function. Fixes: df1bfde4ff0d ("net/sfc: factor out libefx-based Rx datapath") Fixes: 28944ac098aa ("net/sfc: implement Rx queue start and stop operations") Cc: stable@dpdk.org Signed-off-by: Igor Romanov Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/sfc_rx.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/sfc/sfc_rx.c b/drivers/net/sfc/sfc_rx.c index f589ece75..891709fd0 100644 --- a/drivers/net/sfc/sfc_rx.c +++ b/drivers/net/sfc/sfc_rx.c @@ -822,10 +822,12 @@ sfc_rx_qstart(struct sfc_adapter *sa, unsigned int sw_index) return 0; fail_mac_filter_default_rxq_set: + sfc_rx_qflush(sa, sw_index); sa->priv.dp_rx->qstop(rxq_info->dp, &rxq->evq->read_ptr); + rxq_info->state = SFC_RXQ_INITIALIZED; fail_dp_qstart: - sfc_rx_qflush(sa, sw_index); + efx_rx_qdestroy(rxq->common); fail_rx_qcreate: fail_bad_contig_block_size: -- 2.17.1