From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Qi Zhang <qi.z.zhang@intel.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v6 0/3] clean up interrupt handle
Date: Wed, 05 Apr 2017 18:41:13 +0200 [thread overview]
Message-ID: <1584304.2T3CYHfDvM@xps13> (raw)
In-Reply-To: <20170404230908.15145-1-qi.z.zhang@intel.com>
2017-04-05 07:09, Qi Zhang:
> It seems its not necessary to register an intr_handle for interrupt callback
> function. "void* cb_arg" shows enough when be used to pass the object that
> contain the information be required to handle the interrupt event( A typical
> way which is implemented by almost all driver is by passing a rte_ethdev
> instance).
> The patch change the prototype of rte_intr_callback_fn by removing
> the uncessary intr_handle paramter.
Pasting some comments from previous versions:
* You forgot to use --in-reply-to, so it is not convenient to check the history.
* Please keep the the prior acked-by in your patches if there are.
(if think there was a ack for vfio)
* The test patch should be squashed with eal/drivers changes.
New comment:
* New drivers has been added, please rebase and update them.
next prev parent reply other threads:[~2017-04-05 16:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170404230459.15006-1-qi.z.zhang@intel.com>
2017-04-04 23:09 ` Qi Zhang
2017-04-04 23:09 ` [dpdk-dev] [PATCH v6 1/2] vfio: keep interrupt source read only Qi Zhang
2017-04-04 23:09 ` [dpdk-dev] [PATCH v6 2/2] eal: clean up interrupt handle Qi Zhang
2017-04-04 23:09 ` [dpdk-dev] [PATCH v6 3/3] test/test: update test code Qi Zhang
2017-04-05 16:41 ` Thomas Monjalon [this message]
2017-04-06 12:42 ` [dpdk-dev] [PATCH v7 0/2] clean up interrupt handle Qi Zhang
2017-04-06 12:42 ` [dpdk-dev] [PATCH v7 1/2] vfio: keep interrupt source read only Qi Zhang
2017-04-06 19:15 ` Thomas Monjalon
2017-04-06 12:42 ` [dpdk-dev] [PATCH v7 2/2] eal: clean up interrupt handle Qi Zhang
2017-04-06 19:16 ` [dpdk-dev] [PATCH v7 0/2] " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1584304.2T3CYHfDvM@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=qi.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).