From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f173.google.com (mail-wr0-f173.google.com [209.85.128.173]) by dpdk.org (Postfix) with ESMTP id 14A1037B3 for ; Wed, 5 Apr 2017 18:41:14 +0200 (CEST) Received: by mail-wr0-f173.google.com with SMTP id k6so22604164wre.2 for ; Wed, 05 Apr 2017 09:41:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=Fh+7Nbc7f0hNtPAthXYLboiYSyIKYsdjRFiGuYFQ+OA=; b=MsGozDSuBFMRJBRM5nExr9Mse1/FV8pt1VOQrXi8boTLYlODAdMruppE+vN/9kyokg oVutOA3ewdNshv+wQAd6aqU7XTBqIKIjwlCGsFTohtsG2YuGYAM8RXR6nMEpd6Lc3Vw3 1dyLH1eNph49TqtEDwiUpoh1rKQod8KsvDfgbXCVv/nlezZZut9NasVlEIShKmkk1dTR 4cnyA8sVbMkZyGjNeB2LIofv3gSHk50ylOyO/YOoMenlxkJqKr+vSDJ0N34vmThBiFVh uj9KhZ9y1RJKsAdbJv8ICU6z3//DGdMOoGCSHWxQtoDStk+AbUw2Tjx1sjXlLPCkVAfN xVTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=Fh+7Nbc7f0hNtPAthXYLboiYSyIKYsdjRFiGuYFQ+OA=; b=OVE2ZUJA5a0/7thce1Mw96OjtgufuSBM8+ZDPSaM63lZi67Cpe5KpEZlbUZNMlFAWo Mb73lTB/4w37mhHDs0ffrt35rWQcDYf8ty7Nt/Dgj3eDc90cJUHFBmidcjsdI6HAyd2K B5Ekecc8mPAkIn/stnSQpcsYr4nOIwQK1oKcsB7K9FVhKMlQ9guTCq0oV9JPHePkto1q PU1tLqZE/HVSqkIXQ1sWavNnU8rf1DiMEUpywVC2ae/nVO/spT6m/UADAZy36U7ZobQU 2yvi7nwzYEJ3sZCIVp/GTeYKP1wCPIoVx6yE8Cp2EqcV2CaGz2ZxlPnkW/QpfcPf8EIT FXMQ== X-Gm-Message-State: AFeK/H2LkWuO7S3meFgtZjnOT0UbcW+doshFVsjr5Fti+fbwnoY+7roxm98laWUaQpvLrzhO X-Received: by 10.223.155.222 with SMTP id e30mr24757568wrc.165.1491410474612; Wed, 05 Apr 2017 09:41:14 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id y107sm26751821wrc.35.2017.04.05.09.41.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 05 Apr 2017 09:41:13 -0700 (PDT) From: Thomas Monjalon To: Qi Zhang Cc: dev@dpdk.org Date: Wed, 05 Apr 2017 18:41:13 +0200 Message-ID: <1584304.2T3CYHfDvM@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20170404230908.15145-1-qi.z.zhang@intel.com> References: <20170404230459.15006-1-qi.z.zhang@intel.com> <20170404230908.15145-1-qi.z.zhang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v6 0/3] clean up interrupt handle X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Apr 2017 16:41:15 -0000 2017-04-05 07:09, Qi Zhang: > It seems its not necessary to register an intr_handle for interrupt callback > function. "void* cb_arg" shows enough when be used to pass the object that > contain the information be required to handle the interrupt event( A typical > way which is implemented by almost all driver is by passing a rte_ethdev > instance). > The patch change the prototype of rte_intr_callback_fn by removing > the uncessary intr_handle paramter. Pasting some comments from previous versions: * You forgot to use --in-reply-to, so it is not convenient to check the history. * Please keep the the prior acked-by in your patches if there are. (if think there was a ack for vfio) * The test patch should be squashed with eal/drivers changes. New comment: * New drivers has been added, please rebase and update them.