From: Thomas Monjalon <thomas@monjalon.net>
To: Neil Horman <nhorman@tuxdriver.com>
Cc: dev@dpdk.org, "Rao, Nikhil" <nikhil.rao@intel.com>
Subject: Re: [dpdk-dev] [PATCH] check-symbol-change: relax rule for identifying a section
Date: Tue, 21 Aug 2018 11:03:21 +0200 [thread overview]
Message-ID: <1584735.cRL6gNcrux@xps> (raw)
In-Reply-To: <954d81fa-e977-ac7e-8c5f-fbe2fd186bf4@intel.com>
17/08/2018 05:03, Rao, Nikhil:
> On 8/16/2018 4:38 PM, Neil Horman wrote:
> > It was reported recently that some patches that add symbols to an
> > existing EXPERIMENTAL section of a version map file generate errors
> > because the check-symbol-change script was identifying the section as
> > "@@" rather than EXPERIMENTAL. This was fairly clearly due to the fact
> > that the rule identifying the version section expected the whole section
> > to be added, rather than having it already exist, with only new symbols
> > being added to the existing section. This led the match rule to misread
> > the format of that line and pull the wrong word out of it.
> >
> > The fix is to relax the rule slightly. Rather than assume that the
> > section must exist on a line that was added, allow the section name to
> > be set by any line that ends in a '{', which should be correct, given
> > our coding practices. The section name is then extracted as the next to
> > the last word on the line ( $(NF-1) ).
> >
> > Tested by the reporter with good results
> >
> > Reported-by: nikhil.rao@intel.com
> > Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
> >
> Tested-by: Nikhil Rao <nikhil.rao@intel.com>
Applied, thanks
prev parent reply other threads:[~2018-08-21 9:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-16 11:08 Neil Horman
2018-08-17 3:03 ` Rao, Nikhil
2018-08-21 9:03 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1584735.cRL6gNcrux@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=nhorman@tuxdriver.com \
--cc=nikhil.rao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).