From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 009C8A058E; Wed, 25 Mar 2020 04:05:09 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D69072C15; Wed, 25 Mar 2020 04:05:08 +0100 (CET) Received: from huawei.com (szxga06-in.huawei.com [45.249.212.32]) by dpdk.org (Postfix) with ESMTP id 865162BAE; Wed, 25 Mar 2020 04:05:07 +0100 (CET) Received: from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id E6AC15E6FAA137FFC061; Wed, 25 Mar 2020 11:05:05 +0800 (CST) Received: from localhost (10.173.251.152) by DGGEMS412-HUB.china.huawei.com (10.3.19.212) with Microsoft SMTP Server id 14.3.487.0; Wed, 25 Mar 2020 11:04:58 +0800 From: wangyunjian To: CC: , , , Yunjian Wang , Date: Wed, 25 Mar 2020 11:04:56 +0800 Message-ID: <1585105496-18716-1-git-send-email-wangyunjian@huawei.com> X-Mailer: git-send-email 1.9.5.msysgit.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.173.251.152] X-CFilter-Loop: Reflected Subject: [dpdk-dev] [PATCH] net/tap: remove unused assert X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Yunjian Wang The assert checks is not necessary, the gso_ctx is always non-NULL. Fixes: 050316a88313 ("net/tap: support TSO (TCP Segment Offload)") CC: stable@dpdk.org Signed-off-by: Yunjian Wang --- drivers/net/tap/rte_eth_tap.c | 3 --- drivers/net/tap/tap_intr.c | 1 - 2 files changed, 4 deletions(-) diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c index 05470a211..95bea9d77 100644 --- a/drivers/net/tap/rte_eth_tap.c +++ b/drivers/net/tap/rte_eth_tap.c @@ -19,7 +19,6 @@ #include #include -#include #include #include #include @@ -671,8 +670,6 @@ pmd_tx_burst(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts) if (tso) { struct rte_gso_ctx *gso_ctx = &txq->gso_ctx; - assert(gso_ctx != NULL); - /* TCP segmentation implies TCP checksum offload */ mbuf_in->ol_flags |= PKT_TX_TCP_CKSUM; diff --git a/drivers/net/tap/tap_intr.c b/drivers/net/tap/tap_intr.c index 7af0010e3..58f36d3cc 100644 --- a/drivers/net/tap/tap_intr.c +++ b/drivers/net/tap/tap_intr.c @@ -7,7 +7,6 @@ * Interrupts handling for tap driver. */ -#include #include #include #include -- 2.19.1