* [dpdk-dev] [PATCH] doc: update flow non-cached mode notes
@ 2020-04-10 9:36 Bing Zhao
2020-04-10 10:09 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Bing Zhao @ 2020-04-10 9:36 UTC (permalink / raw)
To: john.mcnamara, marko.kovacevic, viacheslavo, matan
Cc: shahafs, rasland, orika, dev, thomas
This patch updates the MLX5 PMD and release notes documentations.
Adding the notes of the behavior change that rte flows organization
is switched into non-cached mode for applications.
Signed-off-by: Bing Zhao <bingz@mellanox.com>
---
doc/guides/nics/mlx5.rst | 10 ++++++++++
doc/guides/rel_notes/release_20_05.rst | 1 +
2 files changed, 11 insertions(+)
diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst
index e13c07d..63138c4 100644
--- a/doc/guides/nics/mlx5.rst
+++ b/doc/guides/nics/mlx5.rst
@@ -1287,6 +1287,16 @@ set, and we should allow to specify zero values as rte_flow parameters for the
META and MARK items and actions. In the same time zero mask has no meaning and
should be rejected on validation stage.
+Notes for rte_flow
+------------------
+Implementation of flows organization is in non-cached mode. When stopping a
+device, all the flows inserted from application will be considered invalid and
+flushed automatically in the background. After restarting of the device, no
+application's flow exists in the system.
+
+The application should re-insert the flows as required after device restarting,
+and must not try to destroy or flush the invalid flows before stopping.
+
Notes for testpmd
-----------------
diff --git a/doc/guides/rel_notes/release_20_05.rst b/doc/guides/rel_notes/release_20_05.rst
index 2596269..3c55445 100644
--- a/doc/guides/rel_notes/release_20_05.rst
+++ b/doc/guides/rel_notes/release_20_05.rst
@@ -62,6 +62,7 @@ New Features
* Added support for matching on IPv4 Time To Live and IPv6 Hop Limit.
* Added support for creating Relaxed Ordering Memory Regions.
+ * Flows organization changed from cached mode to non-cached mode.
* **Updated the Intel ice driver.**
--
2.5.5
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: update flow non-cached mode notes
2020-04-10 9:36 [dpdk-dev] [PATCH] doc: update flow non-cached mode notes Bing Zhao
@ 2020-04-10 10:09 ` Thomas Monjalon
2020-04-10 10:18 ` Bing Zhao
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Monjalon @ 2020-04-10 10:09 UTC (permalink / raw)
To: john.mcnamara, marko.kovacevic, viacheslavo, matan, Bing Zhao
Cc: shahafs, rasland, orika, dev
10/04/2020 11:36, Bing Zhao:
> This patch updates the MLX5 PMD and release notes documentations.
> Adding the notes of the behavior change that rte flows organization
> is switched into non-cached mode for applications.
Please, can it be squashed in the patch doing this change?
> + * Flows organization changed from cached mode to non-cached mode.
I suggest this wording:
Flow rules caching removed from the driver for memory saving.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: update flow non-cached mode notes
2020-04-10 10:09 ` Thomas Monjalon
@ 2020-04-10 10:18 ` Bing Zhao
0 siblings, 0 replies; 3+ messages in thread
From: Bing Zhao @ 2020-04-10 10:18 UTC (permalink / raw)
To: Thomas Monjalon, john.mcnamara, marko.kovacevic, Slava Ovsiienko,
Matan Azrad
Cc: Shahaf Shuler, Raslan Darawsheh, Ori Kam, dev
> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Friday, April 10, 2020 6:10 PM
> To: john.mcnamara@intel.com; marko.kovacevic@intel.com; Slava
> Ovsiienko <viacheslavo@mellanox.com>; Matan Azrad
> <matan@mellanox.com>; Bing Zhao <bingz@mellanox.com>
> Cc: Shahaf Shuler <shahafs@mellanox.com>; Raslan Darawsheh
> <rasland@mellanox.com>; Ori Kam <orika@mellanox.com>;
> dev@dpdk.org
> Subject: Re: [PATCH] doc: update flow non-cached mode notes
>
> 10/04/2020 11:36, Bing Zhao:
> > This patch updates the MLX5 PMD and release notes
> documentations.
> > Adding the notes of the behavior change that rte flows organization
> is
> > switched into non-cached mode for applications.
>
> Please, can it be squashed in the patch doing this change?
>
Hi Thomas, the PMD change was already integrated Into the branch.
I am afraid this couldn't be squashed into the PMD patch.
And this patch is for the notes to the application.
>
> > + * Flows organization changed from cached mode to non-cached
> mode.
>
> I suggest this wording:
>
> Flow rules caching removed from the driver for memory saving.
>
OK, I will change it. Thanks
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-04-10 10:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-10 9:36 [dpdk-dev] [PATCH] doc: update flow non-cached mode notes Bing Zhao
2020-04-10 10:09 ` Thomas Monjalon
2020-04-10 10:18 ` Bing Zhao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).