From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f171.google.com (mail-wr0-f171.google.com [209.85.128.171]) by dpdk.org (Postfix) with ESMTP id 3AB46234 for ; Thu, 9 Mar 2017 17:11:26 +0100 (CET) Received: by mail-wr0-f171.google.com with SMTP id l37so48288761wrc.1 for ; Thu, 09 Mar 2017 08:11:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=Kzw9jFHqd56aCwGHmuUuyTie8ARHOBdtQJyqjQ+tXuU=; b=fSKsFt5MrD1B5GnblrUmEdK8QxgWDhhGbfHR3bfrIDqw1+4NM9CgcBhFhtlPkCXfbv QrDCnsgiiZ9WY0zq/GsDCvA01d5MienWvPHNzJekRA+Rs9LLiOIrJ6CStAi0FbdBdFvI ALHKhTCGYQkgVmv2hxjUDi/H/ZR6+GaNoo6f1+mTKVl1afKOXe276aVjSLoYhuRAJfvm oxUKicYp3184Tv7kQ4VCVdHmUuDf1C0N9Hf8Q9lzmEztvirvEW+YjCEEvXQF16oP8pJf TkldKIlLowfiVbd0oitHp4T+coEvMaMvyEAkp+/mbMCPpS19xHqCJxcX2otMuBxKQJCG QzSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=Kzw9jFHqd56aCwGHmuUuyTie8ARHOBdtQJyqjQ+tXuU=; b=ouyIN3ohOSfu1+MZvTY267ZVjM0Q6T9wEDR/2lqrzvqPGhGgOAPnCMJi9KvgCQSU2F sAN67+p5qk6PH3xzIlnxMQyif9drjTonZj+WU0Osna9quQnbzFqQgFZoi709kWmtTndv EsjRTStCAEdYER2RacOb1yBTpQtrckl92jskCrPh7tU4TdpUGKex4+Q2zJ+QEKTSi9JL b63tBnxpVM57rbF6bHUahPODkaTogFDk2ttdE21GRHJd4zJ//aO4Mki4wg1pasZqeRsk sF3ZOO3cHymA4VLZTo2mOcMlv34EdSGjf8+qSbhqOC62bcocH3B4M1cicI+GTAZPMX4V feeg== X-Gm-Message-State: AMke39lVwMpanFo9hAnXu+nCRk+SDUfUikK7B1cnDECfhR8h3FqfyrVD7UbxfOzkRFzmd0yK X-Received: by 10.223.136.4 with SMTP id d4mr11560105wrd.44.1489075886007; Thu, 09 Mar 2017 08:11:26 -0800 (PST) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id i133sm19472992wmg.26.2017.03.09.08.11.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 09 Mar 2017 08:11:25 -0800 (PST) From: Thomas Monjalon To: Stephen Hemminger Cc: dev@dpdk.org, Ben Walker Date: Thu, 09 Mar 2017 17:11:24 +0100 Message-ID: <1586546.FPT1ddaDYK@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20170217112832.1099e809@plumbers-lap.home.lan> References: <20170131174054.15324-1-benjamin.walker@intel.com> <20170131174453.15796-1-benjamin.walker@intel.com> <20170217112832.1099e809@plumbers-lap.home.lan> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4] eal: Support running as unprivileged user X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Mar 2017 16:11:26 -0000 2017-02-17 11:28, Stephen Hemminger: > On Tue, 31 Jan 2017 10:44:53 -0700 > Ben Walker wrote: > > > + if (physaddr == RTE_BAD_PHYS_ADDR) { > > RTE_LOG(ERR, EAL, > > - "Cannot open /proc/self/pagemap: %s. " > > - "virt2phys address translation will not work\n", > > + "Cannot obtain physical addresses: %s. " > > + "Only vfio will function.\n", > > Please don't split a single error message across multiple lines. It makes > it harder for user to find the source code lines with simple grep. > Better to just have one long line for format string, or better yet be less wordy. > > Yes, the existing DPDK code has lots of these issues. You're right. Here the split is acceptable as there is strerror(errno) in the middle.