DPDK patches and discussions
 help / color / mirror / Atom feed
From: Christos Ricudis <ricudis@niometrics.com>
To: Anatoly Burakov <anatoly.burakov@intel.com>
Cc: dev@dpdk.org, Christos Ricudis <ricudis@niometrics.com>
Subject: [dpdk-dev] [PATCH] eal: Place EAL thread stack in a reserved per-lcore memzone
Date: Mon, 13 Apr 2020 17:09:12 +0800	[thread overview]
Message-ID: <1586768952-10554-1-git-send-email-ricudis@niometrics.com> (raw)

Reserve a per-lcore 4MB memzone and allocate thread stack of EAL threads there for better NUMA locality of stack-allocated variables

Signed-off-by: Christos Ricudis <ricudis@niometrics.com>
---
 lib/librte_eal/linux/eal.c | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/lib/librte_eal/linux/eal.c b/lib/librte_eal/linux/eal.c
index 9530ee5..e047107 100644
--- a/lib/librte_eal/linux/eal.c
+++ b/lib/librte_eal/linux/eal.c
@@ -68,6 +68,8 @@
 
 #define KERNEL_IOMMU_GROUPS_PATH "/sys/kernel/iommu_groups"
 
+#define THREAD_STACK_SIZE_DEFAULT (4ULL * 1024ULL * 1024ULL)
+#include <rte_memzone.h>
 /* Allow the application to print its usage message too if set */
 static rte_usage_hook_t	rte_application_usage_hook = NULL;
 
@@ -1224,6 +1226,24 @@ static void rte_eal_init_alert(const char *msg)
 
 		lcore_config[i].state = WAIT;
 
+		pthread_attr_t attr;
+		pthread_attr_init(&attr);
+		size_t thread_stack_size = THREAD_STACK_SIZE_DEFAULT;
+		char thread_stack_name[64];
+		snprintf(thread_stack_name, sizeof thread_stack_name, "rte:lcore:%s:%d:threadstack", rte_eal_process_type() == RTE_PROC_PRIMARY ? "p" : "s", i);
+		const struct rte_memzone *mz = rte_memzone_lookup(thread_stack_name);
+		if (mz == NULL) {
+			if ((mz = rte_memzone_reserve(thread_stack_name, thread_stack_size, lcore_config[i].socket_id, 0)) == NULL) {
+				rte_panic("Cannot allocate memzone for thread stack");
+			}
+		}
+		void *thread_stack = mz->addr;
+
+		if (pthread_attr_setstack(&attr, thread_stack, thread_stack_size) < 0) {
+			rte_panic("Cannot set thread stack\n");
+		}
+		RTE_LOG(DEBUG, EAL, "Thread stack for lcore %d on socket %d set to %p\n", i, lcore_config[i].socket_id, thread_stack);
+
 		/* create a thread for each lcore */
 		ret = pthread_create(&lcore_config[i].thread_id, NULL,
 				     eal_thread_loop, NULL);
-- 
1.8.3.1


             reply	other threads:[~2020-04-13  9:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-13  9:09 Christos Ricudis [this message]
2020-04-13  9:45 ` Jerin Jacob
2020-04-14 11:23 ` Ananyev, Konstantin
2020-04-27 16:51 ` Pavan Nikhilesh Bhagavatula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1586768952-10554-1-git-send-email-ricudis@niometrics.com \
    --to=ricudis@niometrics.com \
    --cc=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).