DPDK patches and discussions
 help / color / mirror / Atom feed
From: Christos Ricudis <ricudis@niometrics.com>
To: dev@dpdk.org
Cc: arybchenko@solarflare.com, Christos Ricudis <ricudis@niometrics.com>
Subject: [dpdk-dev] [PATCH v2] usertools: decode PCI device name as UTF-8
Date: Tue, 14 Apr 2020 00:18:04 +0800	[thread overview]
Message-ID: <1586794684-19027-1-git-send-email-ricudis@niometrics.com> (raw)
In-Reply-To: <1586789914-10825-1-git-send-email-ricudis@niometrics.com>

Fixes the case where a PCI device string identifier
contains non-ASCII UTF-8

A particular example is Mellanox Connext-X 5 EN MT27800:

28:00.0 Ethernet controller: Mellanox Technologies
MT27800 Family [ConnectX-5]

Subsystem: Mellanox Technologies ConnectX®-5 EN network
interface card, 100GbE single-port QSFP28, PCIe3.0 x16,
tall bracket; MCX515A-CCAT

Signed-off-by: Christos Ricudis <ricudis@niometrics.com>
---
 usertools/dpdk-devbind.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py
index b1d1498..fad0eaa 100755
--- a/usertools/dpdk-devbind.py
+++ b/usertools/dpdk-devbind.py
@@ -211,7 +211,7 @@ def get_pci_device_details(dev_id, probe_lspci):
         for line in extra_info:
             if len(line) == 0:
                 continue
-            name, value = line.decode().split("\t", 1)
+            name, value = line.decode("utf8").split("\t", 1)
             name = name.strip(":") + "_str"
             device[name] = value
     # check for a unix interface name
@@ -257,7 +257,7 @@ def get_device_details(devices_type):
             # Clear previous device's data
             dev = {}
         else:
-            name, value = dev_line.decode().split("\t", 1)
+            name, value = dev_line.decode("utf8").split("\t", 1)
             value_list = value.rsplit(' ', 1)
             if len(value_list) > 1:
                 # String stored in <name>_str
-- 
1.8.3.1


  parent reply	other threads:[~2020-04-13 16:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-13 14:58 [dpdk-dev] [PATCH] " Christos Ricudis
2020-04-13 15:14 ` Andrew Rybchenko
2020-04-13 15:36   ` Christos Rikoudis
2020-04-13 16:18 ` Christos Ricudis [this message]
2020-04-13 16:19   ` [dpdk-dev] [PATCH v2] " Andrew Rybchenko
2020-05-24 17:10     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1586794684-19027-1-git-send-email-ricudis@niometrics.com \
    --to=ricudis@niometrics.com \
    --cc=arybchenko@solarflare.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).