From: Nicolas Chautru <nicolas.chautru@intel.com>
To: dev@dpdk.org, akhil.goyal@nxp.com
Cc: bruce.richardson@intel.com, Nicolas Chautru <nicolas.chautru@intel.com>
Subject: [dpdk-dev] [PATCH v5 06/11] baseband/fpga_5gnr_fec: add HW error capture
Date: Sat, 18 Apr 2020 15:46:43 -0700 [thread overview]
Message-ID: <1587250008-69892-7-git-send-email-nicolas.chautru@intel.com> (raw)
In-Reply-To: <1587250008-69892-1-git-send-email-nicolas.chautru@intel.com>
Adding HW specific parsing of error report for
negative scenarios. Not hit through unit test.
Signed-off-by: Nicolas Chautru <nicolas.chautru@intel.com>
---
drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c | 62 ++++++++++++++++++++--
1 file changed, 59 insertions(+), 3 deletions(-)
diff --git a/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c b/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c
index 2d0fb4f..ed07cab 100644
--- a/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c
+++ b/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c
@@ -519,6 +519,54 @@
return bitmap & bitmask;
}
+/* Print an error if a descriptor error has occurred.
+ * Return 0 on success, 1 on failure
+ */
+static inline int
+check_desc_error(uint32_t error_code) {
+ switch (error_code) {
+ case DESC_ERR_NO_ERR:
+ return 0;
+ case DESC_ERR_K_P_OUT_OF_RANGE:
+ rte_bbdev_log(ERR, "Encode block size K' is out of range");
+ break;
+ case DESC_ERR_Z_C_NOT_LEGAL:
+ rte_bbdev_log(ERR, "Zc is illegal");
+ break;
+ case DESC_ERR_DESC_OFFSET_ERR:
+ rte_bbdev_log(ERR,
+ "Queue offset does not meet the expectation in the FPGA"
+ );
+ break;
+ case DESC_ERR_DESC_READ_FAIL:
+ rte_bbdev_log(ERR, "Unsuccessful completion for descriptor read");
+ break;
+ case DESC_ERR_DESC_READ_TIMEOUT:
+ rte_bbdev_log(ERR, "Descriptor read time-out");
+ break;
+ case DESC_ERR_DESC_READ_TLP_POISONED:
+ rte_bbdev_log(ERR, "Descriptor read TLP poisoned");
+ break;
+ case DESC_ERR_CB_READ_FAIL:
+ rte_bbdev_log(ERR, "Unsuccessful completion for code block");
+ break;
+ case DESC_ERR_CB_READ_TIMEOUT:
+ rte_bbdev_log(ERR, "Code block read time-out");
+ break;
+ case DESC_ERR_CB_READ_TLP_POISONED:
+ rte_bbdev_log(ERR, "Code block read TLP poisoned");
+ break;
+ case DESC_ERR_HBSTORE_ERR:
+ rte_bbdev_log(ERR, "Hbstroe exceeds HARQ buffer size.");
+ break;
+ default:
+ rte_bbdev_log(ERR, "Descriptor error unknown error code %u",
+ error_code);
+ break;
+ }
+ return 1;
+}
+
/* Compute value of k0.
* Based on 3GPP 38.212 Table 5.4.2.1-2
* Starting position of different redundancy versions, k0
@@ -982,11 +1030,11 @@
static inline int
dequeue_ldpc_enc_one_op_cb(struct fpga_queue *q,
- struct rte_bbdev_enc_op **op __rte_unused,
+ struct rte_bbdev_enc_op **op,
uint16_t desc_offset)
{
union fpga_dma_desc *desc;
-
+ int desc_error;
/* Set current desc */
desc = q->ring_addr + ((q->head_free_desc + desc_offset)
& q->sw_ring_wrap_mask);
@@ -1000,6 +1048,11 @@
rte_bbdev_log_debug("DMA response desc %p", desc);
+ *op = desc->enc_req.op_addr;
+ /* Check the descriptor error field, return 1 on error */
+ desc_error = check_desc_error(desc->enc_req.error);
+ (*op)->status = desc_error << RTE_BBDEV_DATA_ERROR;
+
return 1;
}
@@ -1009,7 +1062,7 @@
uint16_t desc_offset)
{
union fpga_dma_desc *desc;
-
+ int desc_error;
/* Set descriptor */
desc = q->ring_addr + ((q->head_free_desc + desc_offset)
& q->sw_ring_wrap_mask);
@@ -1036,6 +1089,9 @@
(*op)->status = 1 << RTE_BBDEV_CRC_ERROR;
/* et_pass = 0 when decoder fails */
(*op)->status |= !(desc->dec_req.et_pass) << RTE_BBDEV_SYNDROME_ERROR;
+ /* Check the descriptor error field, return 1 on error */
+ desc_error = check_desc_error(desc->dec_req.error);
+ (*op)->status |= desc_error << RTE_BBDEV_DATA_ERROR;
return 1;
}
--
1.8.3.1
next prev parent reply other threads:[~2020-04-18 22:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-18 22:46 [dpdk-dev] [PATCH v5 00/11] drivers/baseband: PMD for FPGA 5GNR FEC Nicolas Chautru
2020-04-18 22:46 ` [dpdk-dev] [PATCH v5 01/11] drivers/baseband: add " Nicolas Chautru
2020-04-18 22:46 ` [dpdk-dev] [PATCH v5 02/11] baseband/fpga_5gnr_fec: add register definition file Nicolas Chautru
2020-04-18 22:46 ` [dpdk-dev] [PATCH v5 03/11] baseband/fpga_5gnr_fec: add info_get function Nicolas Chautru
2020-04-18 22:46 ` [dpdk-dev] [PATCH v5 04/11] baseband/fpga_5gnr_fec: add queue configuration Nicolas Chautru
2020-04-18 22:46 ` [dpdk-dev] [PATCH v5 05/11] baseband/fpga_5gnr_fec: add LDPC processing functions Nicolas Chautru
2020-04-18 22:46 ` Nicolas Chautru [this message]
2020-04-18 22:46 ` [dpdk-dev] [PATCH v5 07/11] baseband/fpga_5gnr_fec: add debug functionality Nicolas Chautru
2020-04-18 22:46 ` [dpdk-dev] [PATCH v5 08/11] baseband/fpga_5gnr_fec: add configure function Nicolas Chautru
2020-04-18 22:46 ` [dpdk-dev] [PATCH v5 09/11] baseband/fpga_5gnr_fec: add harq loopback capability Nicolas Chautru
2020-04-18 22:46 ` [dpdk-dev] [PATCH v5 10/11] baseband/fpga_5gnr_fec: add interrupt support Nicolas Chautru
2020-04-18 22:46 ` [dpdk-dev] [PATCH v5 11/11] doc: add feature matrix table for bbdev devices Nicolas Chautru
2020-04-19 15:37 ` [dpdk-dev] [PATCH v5 00/11] drivers/baseband: PMD for FPGA 5GNR FEC Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1587250008-69892-7-git-send-email-nicolas.chautru@intel.com \
--to=nicolas.chautru@intel.com \
--cc=akhil.goyal@nxp.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).