From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E5BC1A00BE; Wed, 29 Apr 2020 15:06:22 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 73FDA1DACF; Wed, 29 Apr 2020 15:06:22 +0200 (CEST) Received: from git-send-mailer.rdmz.labs.mlnx (unknown [37.142.13.130]) by dpdk.org (Postfix) with ESMTP id D7DF01DACE; Wed, 29 Apr 2020 15:06:21 +0200 (CEST) From: Bing Zhao To: viacheslavo@mellanox.com, rasland@mellanox.com Cc: orika@mellanox.com, matan@mellanox.com, dev@dpdk.org, stable@dpdk.org Date: Wed, 29 Apr 2020 21:06:14 +0800 Message-Id: <1588165574-237391-1-git-send-email-bingz@mellanox.com> X-Mailer: git-send-email 1.8.3.1 Subject: [dpdk-dev] [PATCH] net/mlx5: fix wrong assert in modify converting X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The assertion was added incorrectly in converting the modify actions into the format of low layer driver. There is no mask specified in the rte_flow actions, and PMD dirver will give a mask of all 1s to the field to be modified. For each field, the mask could not be zero. But for the whole header which contains this field, the masks of other fields could be zero. The assertion needs to be removed for debug mode. Fixes: 72a944dba163 ("net/mlx5: fix header modify action validation") Cc: stable@dpdk.org Signed-off-by: Bing Zhao Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_flow_dv.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c index 6263ecc..8cd9c83 100644 --- a/drivers/net/mlx5/mlx5_flow_dv.c +++ b/drivers/net/mlx5/mlx5_flow_dv.c @@ -434,7 +434,6 @@ struct field_modify_info modify_tcp[] = { /* Fetch variable byte size mask from the array. */ mask = flow_dv_fetch_field((const uint8_t *)item->mask + field->offset, field->size); - MLX5_ASSERT(mask); if (!mask) { ++field; continue; -- 1.8.3.1