From: Thomas Monjalon <thomas@monjalon.net>
To: "Awal, Mohammad Abdul" <mohammad.abdul.awal@intel.com>
Cc: "Yigit, Ferruh" <ferruh.yigit@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"arybchenko@solarflare.com" <arybchenko@solarflare.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 1/3] ethdev: fix null pointer checking
Date: Wed, 03 Apr 2019 20:42:35 +0200 [thread overview]
Message-ID: <1588223.P5TngShShd@xps> (raw)
In-Reply-To: <53CAEE02C005744990339697D6A8BBC20352A87A@IRSMSX107.ger.corp.intel.com>
03/04/2019 19:30, Awal, Mohammad Abdul:
> From: Yigit, Ferruh
> > On 4/3/2019 5:27 PM, Thomas Monjalon wrote:
> > > 03/04/2019 18:07, Mohammad Abdul Awal:
> > >> Null value for parameter name will cause segfault for the
> > >> strnlen and strcmp functions.
> > >
> > > I'm not sure we want such obvious checks for all APIs.
> > > Here I would say yes.
> >
> > These are internal functions, not APIs.
> > I am for verifying input for (all) APIs but not for internal functions, drivers
> > should call them and they are in our control, if they are passing NULL we can
> > fix them :)
>
> The null checks are for the input param "char *name" of APIs rte_eth_dev_allocate and rte_eth_dev_attach_secondary.
> I will change the err msg to suggested one.
As Ferruh said, these are not really API in the sense that they
are not called by the applications but only by drivers.
PS: please write replies below original text.
next prev parent reply other threads:[~2019-04-03 18:42 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-03 16:07 Mohammad Abdul Awal
2019-04-03 16:07 ` Mohammad Abdul Awal
2019-04-03 16:27 ` Thomas Monjalon
2019-04-03 16:27 ` Thomas Monjalon
2019-04-03 16:35 ` Ferruh Yigit
2019-04-03 16:35 ` Ferruh Yigit
2019-04-03 16:41 ` Bruce Richardson
2019-04-03 16:41 ` Bruce Richardson
2019-04-03 16:52 ` Ferruh Yigit
2019-04-03 16:52 ` Ferruh Yigit
2019-04-03 17:32 ` David Marchand
2019-04-03 17:32 ` David Marchand
2019-04-04 8:33 ` Mohammad Abdul Awal
2019-04-04 8:33 ` Mohammad Abdul Awal
2019-04-03 17:30 ` Awal, Mohammad Abdul
2019-04-03 17:30 ` Awal, Mohammad Abdul
2019-04-03 18:42 ` Thomas Monjalon [this message]
2019-04-03 18:42 ` Thomas Monjalon
2019-04-03 18:50 ` Stephen Hemminger
2019-04-03 18:50 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1588223.P5TngShShd@xps \
--to=thomas@monjalon.net \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=mohammad.abdul.awal@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).