From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
Cc: dev@dpdk.org, Hayato Momma <h-momma@ce.jp.nec.com>
Subject: Re: [dpdk-dev] [memnic PATCH 3/5] pmd: implement stats of MEMNIC
Date: Mon, 24 Mar 2014 16:25:44 +0100 [thread overview]
Message-ID: <1588240.i7QGELTBWt@xps13> (raw)
In-Reply-To: <7F861DC0615E0C47A872E6F3C5FCDDBD01073B19@BPXM14GP.gisp.nec.co.jp>
Hi,
11/03/2014 05:38, Hiroshi Shimamoto:
> From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
>
> Implement missing feature to account statistics.
> This patch adds just an infrastructure.
>
> Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
> Reviewed-by: Hayato Momma <h-momma@ce.jp.nec.com>
[...]
> @@ -51,6 +51,7 @@ struct memnic_adapter {
> int up_idx, down_idx;
> struct rte_mempool *mp;
> struct ether_addr mac_addr;
> + struct rte_eth_stats stats[RTE_MAX_LCORE];
> };
Could you make a comment to explain why you allocate a structure per core?
It is easier to read when locking strategy is described.
> + for (i = 0; i < RTE_MAX_LCORE; i++) {
> + struct rte_eth_stats *st = &adapter->stats[i];
> +
> + memset(st, 0, sizeof(*st));
> + }
Could you use only one memset for the array?
--
Thomas
next prev parent reply other threads:[~2014-03-24 15:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-11 5:38 Hiroshi Shimamoto
2014-03-24 15:25 ` Thomas Monjalon [this message]
2014-03-25 8:23 ` Hiroshi Shimamoto
2014-03-25 15:00 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1588240.i7QGELTBWt@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=h-momma@ce.jp.nec.com \
--cc=h-shimamoto@ct.jp.nec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).